Skip to content

Fix z-fighting on outline waypoints #1988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
InspectorBoat wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix z-fighting on outline waypoints #1988

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/main/java/de/hysky/skyblocker/utils/render/primitive/PrimitiveCollectorImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,8 @@ public final class PrimitiveCollectorImpl implements PrimitiveCollector {
private List<OutlinedCircleRenderState> outlinedCircleStates = null;
private boolean frozen = false;

private static final double DELTA = 0.0005;

public PrimitiveCollectorImpl(LevelRenderState worldState, Frustum frustum) {
this.worldState = worldState;
this.frustum = frustum;
Expand Down Expand Up @@ -144,7 +146,8 @@ private void submitBeaconBeam(BlockPos pos, float[] colourComponents) {

@Override
public void submitOutlinedBox(BlockPos pos, float[] colourComponents, float lineWidth, boolean throughWalls) {
submitOutlinedBox(pos.getX(), pos.getY(), pos.getZ(), pos.getX() + 1, pos.getY() + 1, pos.getZ() + 1, colourComponents, 1f, lineWidth, throughWalls);
// Only this function needs a delta, in order to fix z-fighting with the block outline
submitOutlinedBox(pos.getX() - DELTA, pos.getY() - DELTA, pos.getZ() - DELTA, pos.getX() + 1 + DELTA, pos.getY() + 1 + DELTA, pos.getZ() + 1 + DELTA, colourComponents, 1f, lineWidth, throughWalls);
}

@Override
Expand Down