Open
Conversation
Collaborator
Author
|
This was tested. Only booleans are supported for now. Should be pretty simple to review. |
Alex33856
requested changes
Jan 24, 2026
src/main/java/de/hysky/skyblocker/config/SkyblockerConfigManager.java
Outdated
Show resolved
Hide resolved
| return literal(name).executes(Scheduler.queueOpenScreenCommand(() -> createGUI(null))) | ||
| .then(argument("option", StringArgumentType.greedyString()).executes((ctx) -> Scheduler.queueOpenScreen(createGUI(null, ctx.getArgument("option", String.class))))); | ||
| LiteralArgumentBuilder<FabricClientCommandSource> builder = literal(name).executes(Scheduler.queueOpenScreenCommand(() -> createGUI(null))) | ||
| .then(literal("search").then(argument("option", StringArgumentType.greedyString()).executes((ctx) -> Scheduler.queueOpenScreen(createGUI(null, ctx.getArgument("option", String.class)))))); |
Contributor
There was a problem hiding this comment.
This makes searching from the command more annoying... Maybe the other stuff can be a different subcommand.
Collaborator
Author
There was a problem hiding this comment.
I can’t think of anything unfortunately. The only thing I thought of is /skyblocker config command …. set doesn’t really work here because you can also query.
LifeIsAParadox
added
changes requested
LifeIsAParadox
added
reviews needed
viciscat
reviewed
Jan 29, 2026
Collaborator
viciscat
left a comment
viciscat
left a comment
There was a problem hiding this comment.
Small nitpick i guess, not gonna request changes since it's minor and it isn't that important from avoiding duplicate code a bit
Alex33856
added
merge conflicts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows you to modify the config with commands.