Open
Conversation
I can't remember but i think this is just fixing some small bugs
AzureAaron
reviewed
Feb 6, 2026
|
|
||
| private class ListContainer extends AbstractContainerWidget { | ||
|
|
||
| ListContainer(int i, int j, int k, int l) { |
Collaborator
There was a problem hiding this comment.
could copy the parameter names from mcsrc.dev
|
|
||
| "skyblocker.utils.locationUpdateError": "Failed to update your location! Some features of the mod may not work properly :(", | ||
| "skyblocker.utils.render.gui.soundSelectionPopup.advanced": "Advanced", | ||
| "skyblocker.utils.render.gui.soundSelectionPopup.advanced.@Tooltip": "Show sounds without a propper name", |
Collaborator
There was a problem hiding this comment.
Should end with a period
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creates a popup menu to select from all the sounds in the game. I have only added it to chatrules for this PR but I think there are quite a few places where it would be nice to be able to select a sound.
ps: This has been half done for about a month so I might have forgotten about something I was going to do