Add option for Stereo Harmony to color pests differently#2125
Open
LJNeon wants to merge 8 commits intoSkyblockerMod:masterfrom
Open
Add option for Stereo Harmony to color pests differently#2125LJNeon wants to merge 8 commits intoSkyblockerMod:masterfrom
LJNeon wants to merge 8 commits intoSkyblockerMod:masterfrom
Conversation
LifeIsAParadox
added
reviews needed
Alex33856
requested changes
Feb 20, 2026
src/main/java/de/hysky/skyblocker/skyblock/entity/glow/adder/GardenGlowAdder.java
Outdated
Show resolved
Hide resolved
LifeIsAParadox
added
changes requested
LifeIsAParadox
added
merge conflicts
LJNeon
force-pushed
the
pest-vinyls-glow
branch
from
53fc468 to
518dad3
Compare
Alex33856
reviewed
Feb 24, 2026
Co-authored-by: Alex <8379108+Alex33856@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have tested this PR thoroughly and it appears to work without any issues. If the aqua color is undesirable I'm happy to swap it to another color. I'm not very familiar with Java nor minecraft modding APIs so I want a more in-depth review of the implementation if possible.
fixes #1982
Testing & Screenshots:
During a Jacob's Contest (for Wild Roses & Pray For Me vinyl selected):
After the contest ended:
Switched to the Rodent Revolution vinyl:
Deselected the vinyl (so none are selected):
Disabled the configuration option and selected Pray For Me vinyl:
Enabled Stereo Harmony option & disabled Vinyl Highlighter option:
