Don't show AH price on non-transferable rift items while in the rift#2128
Open
LJNeon wants to merge 2 commits intoSkyblockerMod:masterfrom
Open
Don't show AH price on non-transferable rift items while in the rift#2128LJNeon wants to merge 2 commits intoSkyblockerMod:masterfrom
LJNeon wants to merge 2 commits intoSkyblockerMod:masterfrom
Conversation
Contributor
Author
|
ItemUtils.getLoreLineIf(stack, line -> line.contains("Rift-Transferable")) == nullItemUtils.getCustomData(stack).getIntOr("rift_transferable", 0) == 0!ItemUtils.getCustomData(stack).getBooleanOr("rift_transferable", false)(or any other method I wasn't able to find) |
Collaborator
|
It would be better to just remove the price from the items in the api. |
Contributor
Author
|
I believe when I mentioned that before I was told those items do exist outside of the rift as rare collectables due to past bugs. But if that's not an issue then I agree completely. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this change:

After this change:

Transferable items remain unchanged:

fixes #1883