Skip to content

Comments

Don't show AH price on non-transferable rift items while in the rift#2128

Open
LJNeon wants to merge 2 commits intoSkyblockerMod:masterfrom
LJNeon:rift-non-transferable-ah
Open

Don't show AH price on non-transferable rift items while in the rift#2128
LJNeon wants to merge 2 commits intoSkyblockerMod:masterfrom
LJNeon:rift-non-transferable-ah

Conversation

@LJNeon
Copy link
Contributor

@LJNeon LJNeon commented Feb 13, 2026

Before this change:
image

After this change:
after-change

Transferable items remain unchanged:
after-transferable

fixes #1883

@LifeIsAParadox LifeIsAParadox added the reviews needed This PR needs reviews label Feb 13, 2026
@LJNeon
Copy link
Contributor Author

LJNeon commented Feb 13, 2026

One question for any reviewers, which of these would be better to use when determining if an item is non-transferable? I swear there was a rift_transferable in the item's custom data but now I can't find it... so I guess only the first option works?

ItemUtils.getLoreLineIf(stack, line -> line.contains("Rift-Transferable")) == null
ItemUtils.getCustomData(stack).getIntOr("rift_transferable", 0) == 0
!ItemUtils.getCustomData(stack).getBooleanOr("rift_transferable", false)

(or any other method I wasn't able to find)

@AzureAaron
Copy link
Collaborator

It would be better to just remove the price from the items in the api.

@LJNeon
Copy link
Contributor Author

LJNeon commented Feb 17, 2026

I believe when I mentioned that before I was told those items do exist outside of the rift as rare collectables due to past bugs. But if that's not an issue then I agree completely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

reviews needed This PR needs reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hide AH info on non-transferable rift items while in the rift

3 participants