Implement spf13/cobra in daemon#6
Open
Kifen wants to merge 12 commits intoSkycoinProject:masterfrom
Kifen:refactor/cobra_cli
Open
Implement spf13/cobra in daemon#6Kifen wants to merge 12 commits intoSkycoinProject:masterfrom Kifen:refactor/cobra_cli
Kifen wants to merge 12 commits intoSkycoinProject:masterfrom
Kifen:refactor/cobra_cli
Conversation
Collaborator
|
@Kifen could you add a |
jdknives
reviewed
Feb 18, 2020
|
|
||
| var rootCmd = &cobra.Command{ | ||
| Use: "skywire-peering-daemon", | ||
| Short: "A skywire-peering-skywire-peering-daemon", |
Contributor
Author
There was a problem hiding this comment.
Very true. Refactored it to a long description.
Collaborator
|
Please add a default target as well like that |
nkryuchkov
suggested changes
Feb 22, 2020
| ${OPTS} golangci-lint run -c .golangci.yml ./... | ||
| # The govet version in golangci-lint is out of date and has spurious warnings, run it separately | ||
| ${OPTS} go vet -all ./... | ||
| # The govet version in golangci-lint is out of date and has spurious warnings |
There was a problem hiding this comment.
Is there a reason for removing ${OPTS} go vet -all ./...?
Contributor
Author
There was a problem hiding this comment.
Not at all. Removed it unknowingly...
|
|
||
| // Daemon provides configuration parameters for a | ||
| // skywire-peering-daemon. | ||
| // skywire-peering-skywire-peering-daemon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5