Skip to content

Conversation

@samsternberg
Copy link
Contributor

Summary

Changes the default value for service account creation from false to true to provide a better out-of-box experience. Service accounts and API keys are essential for data operations commands.

Changes

  • Updated command option default in createVault.ts from false to true
  • Updated interactive prompt default in prompts.ts from false to true

Test plan

  • Run sky create-vault without the --create-service-account flag
  • Verify the interactive prompt defaults to "Yes"
  • Verify service account is created by default

Fixes #18

🤖 Generated with Claude Code

Update default value from false to true for --create-service-account
option and interactive prompt. Service accounts are essential for data
operations (insert, deidentify, reidentify), so creating them by
default provides a better out-of-box experience.

Fixes #18

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@github-actions
Copy link

Gitleaks Findings: No secrets detected. Safe to proceed!

@samsternberg samsternberg requested a review from jstjoe November 13, 2025 16:05
Copy link
Contributor

@jstjoe jstjoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jstjoe jstjoe merged commit bf8b9ce into main Nov 14, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Change default for service account creation to true

3 participants