-
Notifications
You must be signed in to change notification settings - Fork 35
Bump @skyscanner/bpk-foundations-android from 23.0.0 to 24.0.0 #2533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump @skyscanner/bpk-foundations-android from 23.0.0 to 24.0.0 #2533
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
Generated by 🚫 Danger Kotlin against 724afd9 |
|
Dependabot (@dependabot) recreate |
724afd9 to
7a6fee9
Compare
Generated by 🚫 Danger Kotlin against 299f559 |
|
A newer version of @skyscanner/bpk-foundations-android exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged. |
|
Dependabot (@dependabot) recreate |
299f559 to
3fca246
Compare
Generated by 🚫 Danger Kotlin against 59c0167 |
Generated by 🚫 Danger Kotlin against 434dbff |
Generated by 🚫 Danger Kotlin against b6b3bd9 |
Bumps [@skyscanner/bpk-foundations-android](https://github.com/Skyscanner/backpack-foundations) from 23.0.0 to 24.0.0. - [Release notes](https://github.com/Skyscanner/backpack-foundations/releases) - [Commits](Skyscanner/backpack-foundations@23.0.0...24.0.0) --- updated-dependencies: - dependency-name: "@skyscanner/bpk-foundations-android" dependency-version: 24.0.0 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Claude <noreply@anthropic.com>
b6b3bd9 to
56e1bb3
Compare
Generated by 🚫 Danger Kotlin against 56e1bb3 |
Generated by 🚫 Danger Kotlin against f6923bf |
The zizmor security fixes added persist-credentials: false which broke git push operations. This fix manually configures the git remote URL with the app token only in steps that need to push, maintaining the security benefits while restoring push functionality. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Generated by 🚫 Danger Kotlin against 25b686b |
Generated by 🚫 Danger Kotlin against b9e33a0 |
The zizmor security fixes added persist-credentials: false which broke git push operations. This fix manually configures the git remote URL with the app token only in steps that need to push, maintaining the security benefits while restoring push functionality. Uses environment variables to avoid template injection warnings. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Generated by 🚫 Danger Kotlin against 2c0c132 |
| val ripple = ripple(bounded = true, color = BpkTheme.colors.textLink) | ||
| val ripple = ripple(bounded = true, color = BpkTheme.colors.corePrimary) | ||
| val transition = updateTransition(targetState = selected, label = "HorizontalNav.Tab transition") | ||
| val color by transition.animateColor( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this removal of animation expected?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes it's not changing any more
https://www.figma.com/design/KXf2gHNLDe2cXWUoHl4cTX/Backpack%E2%80%A8Foundations---Components?node-id=10908-4770&m=dev
Co-authored-by: Claude <noreply@anthropic.com>
By approving this PR, you are confirming that you have adequately and effectively reviewed this change.
Searchable Hashes
The above information was added by dependabot-augmentor.
Bumps @skyscanner/bpk-foundations-android from 23.0.0 to 24.0.0.
Release notes
Sourced from
@skyscanner/bpk-foundations-android's releases.Commits
5cb6fe1[SDBCK-61]add new primitive token & update secondary-on-dark button press col...bb72d2aDeprecate text link colour (#483)5d44a45[DON-1112] Deprecate core eco color (#484)fbad455[CLOV-962]remove storybook entry for private colors (#479)b180c6c[NO-JIRA]add chip color story (#478)5d328ac[DON-2262] - Added colour token to chip.json (#476)e73a1e5DON-2227 add full radius to foundations android/ios (#477)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)