Skip to content

Conversation

@grc-ong
Copy link

@grc-ong grc-ong commented Jan 23, 2026

Remember to include the following changes:

  • Ensure the PR title includes the name of the component you are changing so it's clear in the release notes for consumers of the changes in the version e.g [Clover-123][BpkButton] Updating the colour
  • README.md (If you have created a new component)
  • Component README.md
  • Tests
  • Accessibility tests
    • The following checks were performed:
      • Ability to navigate using a keyboard only
      • Zoom functionality (Deque University explanation):
        • The page SHOULD be functional AND readable when only the text is magnified to 200% of its initial size
        • Pages must reflow as zoom increases up to 400% so that content continues to be presented in only one column i.e. Content MUST NOT require scrolling in two directions (both vertically and horizontally)
      • Ability to navigate using a screen reader only
  • Storybook examples created/updated
  • For breaking changes or deprecating components/properties, migration guides added to the description of the PR. If the guide has large changes, consider creating a new Markdown page inside the component's docs folder and link it here

@skyscanner-backpack-bot
Copy link

skyscanner-backpack-bot bot commented Jan 23, 2026

Warnings
⚠️

Package source files (e.g. packages/package-name/src/Component.js) were updated, but snapshots weren't. Have you checked that the tests still pass?

Browser support

If this is a visual change, make sure you've tested it in multiple browsers.

Generated by 🚫 dangerJS against f2a2f9d

@skyscanner-backpack-bot
Copy link

Visit https://backpack.github.io/storybook-prs/4138 to see this build running in a browser.

@grc-ong grc-ong added enhancement minor Non breaking change labels Jan 23, 2026
@grc-ong grc-ong changed the title [IRN-6718] WIP: add physical page-based scrolling to desktop [IRN-6718] [BpkCardListCarousel] Add physical page-based scrolling to desktop Jan 23, 2026
@skyscanner-backpack-bot
Copy link

Visit https://backpack.github.io/storybook-prs/4138 to see this build running in a browser.

@skyscanner-backpack-bot
Copy link

Visit https://backpack.github.io/storybook-prs/4138 to see this build running in a browser.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement minor Non breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants