User Restriction #62
Merged
User Restriction #62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
Author
|
TODO:
|
Contributor
There was a problem hiding this comment.
A few notes:
durationshould accept a RustDuration- the
idempotency_keyshould be optional - as we discussed in DMs, the update mask needs to be applied atomically
- generally speaking I don't understand why Roblox users are passed as strings, but I see this occurring in the rest of the library as well
- the timestamps should be
chronotimestamps, not strings
All of these string types make it feel less like a library and more like a json/reqwest wrapper!
Contributor
|
Hey @Sleitnick, are you still planning on finishing this up? Thank you! |
Owner
Author
|
@jackTabsCode Sorry for the delay. I'm looking into trying to get this into v0.17.0. |
Sleitnick
added a commit
that referenced
this pull request
Mar 23, 2025
* Luau execution impl (#72) * Luau execution impl * Luau execution client impl * Luau execution CLI stub * Luau execution CLI * Docs * Log query params * Bump version * Inventory API (#73) * Start inventory impl * Collectible details * Doc stub * Inventory client * Inventory CLI stub * Inventory CLI impl * Inventory CLI docs * Serial number optional * Remove print * Clean up warnings * User Restriction (#62) * User restriction API and client * Readme * User restriction CLI * Small fixes * DateTime timestamp * Optional idempotency key * Docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #53