-
Notifications
You must be signed in to change notification settings - Fork 268
Add SlicerDBSCoalignment extension #2161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hello, This module is designed to Coalign electrodes and refine their positions in DBS surgeries. |
Hi - thanks for the contribution and the ping. I know people are busy and haven't had time to review. I took a quick look and I think this looks good for a Tier 1 module. We are trying to use the tier 1 process to unclog the review process but since you can also install without the extension manager feel free to publicize your work and then just change the readme when it gets reviewed. One suggestion on the readme is to describe a bit more context of the kind of experiments this would be used for (I assume it's for mice, right?). |
Dear Steve, Thank you for your reply. I was curious whether I submitted correctly. Thanks Igor |
The automatic validation checks have some issues. Could you fix them? If you have any questions then let us know. |
Thanks for the update! A few checks are still failing: ❌ Check CMakeLists.txt content failed: CMakeLists.txt file not found in repository root Fix: move https://github.com/IVarha/SlicerDBSCoalignment/tree/master/slicer_mer_stn folder content to the repository root folder ❌ Check category failed: Category Netsim is unknown. Consider using any of the known extensions instead: Active Learning, Analysis, Auto3dgm, BigImage, Cardiac, Chest Imaging Platform, Conda, Converters, DICOM, DSCI, Developer Tools, Diffusion, Examples, Exporter, FTV Segmentation, Filtering, Filtering.Morphology, Filtering.Vesselness, Holographic Display, IGT, Informatics, Netstim, Neuroimaging, Nuclear Medicine, Orthodontics, Osteotomy Planning, Otolaryngology, Photogrammetry, Pipelines, Planning, Printing, Quantification, Radiotherapy, Registration, Remote, Rendering, SPHARM, Segmentation, Sequences, Shape Analysis, Shape Regression, Shape Visualization, Simulation, SlicerCMF, SlicerMorph, Spectral Imaging, Supervisely, Surface Models, SurfaceLearner, Tomographic Reconstruction, Tracking, Tractography, Training, Ultrasound, Utilities, Vascular Modeling Toolkit, Virtual Reality, VisSimTools, Web System Tools, Wizards Fix: fix typo ( |
Dear Andras, |
81797a9
to
2f0bb6f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, it all looks good now.
In the long term, it would be nice to replace the tensorflow dependency with pytorch so that users can simply install the Slicer extension without messing with additional Python environments, but I understand that this may not be easy.
Adding DBS Coalignment project to coalign MER signals within STN for PD surgeries
New extension
Tier 1
Any extension that is listed in the Extensions Catalog must fulfill these requirements.
3d-slicer-extension
GitHub topic so that it is listed here. To edit topics, click the settings icon in the right side of "About" section header and enter3d-slicer-extension
in "Topics" and click "Save changes". To learn more about topics, read https://help.github.com/en/articles/about-topicsSettings
and in repository settings uncheckWiki
,Projects
, andDiscussions
(if they are currently not used).About
in the top-right corner of the repository main page and uncheckReleases
andPackages
(if they are currently not used)