Skip to content

Updating matter rvc ux #2343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Updating matter rvc ux #2343

wants to merge 7 commits into from
+85 −725

Conversation

HunsupJung
Copy link
Collaborator

@HunsupJung HunsupJung commented Aug 15, 2025 •
edited
Loading

Type of Change

  • WWST Certification Request
    • If this is your first time contributing code:
      • I have reviewed the README.md file
      • I have reviewed the CODE_OF_CONDUCT.md file
      • I have signed the CLA
    • I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
  • Bug fix
  • New feature
  • Refactor

Checklist

  • I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have verified my changes by testing with a device or have communicated a plan for testing
  • I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

The unnecessary mode capability for Run Mode cluster has been deleted.

Summary of Completed Tests

This feature is being tested with following TC in SVT.
https://smartthings.atlassian.net/wiki/spaces/STHK/pages/4088660856/REQ-22349+Matter+RVC+UX+Upgrade+TC

@HunsupJung
Upgrade matter-rvc driver
ceae111 
 - Integrate components
 - Remove mode capability for run mode cluster

Signed-off-by: HunsupJung <hunsup.jung@samsung.com>
@HunsupJung
Update Test Unit
355860d 
Signed-off-by: HunsupJung <hunsup.jung@samsung.com>
@HunsupJung HunsupJung changed the title Feature/updating matter rvc ux Updating matter rvc ux Aug 15, 2025
@github-actions GitHub Actions
Copy link

Duplicate profile check: Passed - no duplicate profiles detected.

@github-actions GitHub Actions
Copy link

Invitation URL:
https://bestow-regional.api.smartthings.com/invite/1J2QnYXzqkl0

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 15, 2025 •
edited
Loading

Test Results

   69 files    449 suites   0s ⏱️
2 336 tests 2 336 ✅ 0 💤 0 ❌
3 929 runs  3 929 ✅ 0 💤 0 ❌

Results for commit 93942f6.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 15, 2025 •
edited
Loading

File Coverage
All files 73% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-rvc/src/ServiceArea/types/LandmarkInfoStruct.lua 59% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-rvc/src/ServiceArea/types/AreaInfoStruct.lua 59% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-rvc/src/ServiceArea/types/AreaStruct.lua 63% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-rvc/src/ServiceArea/types/SelectAreasStatus.lua 69% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-rvc/src/init.lua 89% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-rvc/src/embedded_cluster_utils.lua 72% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-rvc/src/Global/types/AreaTypeTag.lua 66% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-rvc/src/Global/types/LandmarkTag.lua 67% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-rvc/src/Global/types/RelativePositionTag.lua 68% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-rvc/src/Global/types/LocationDescriptorStruct.lua 63% ❌

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against 93942f6

@HunsupJung
Fix failed part on luacheck
df9744e 
Signed-off-by: HunsupJung <hunsup.jung@samsung.com>
@HunsupJung HunsupJung force-pushed the feature/updating-matter-rvc-ux branch from d1c20d1 to df9744e Compare August 15, 2025 10:31
nickolas-deboom
nickolas-deboom reviewed Aug 18, 2025
View reviewed changes
drivers/SmartThings/matter-rvc/src/init.lua Outdated
local function component_to_endpoint(device, component_name)
-- Use the find_default_endpoint function to return the first endpoint that
-- supports a given cluster.
return find_default_endpoint(device, clusters.RvcOperationalState.ID)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does the endpoint structure typically look like for a RVC? Are the clusters usually all implemented on the same endpoint?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I not sure, but Roborock implements Power Source, RVC Run Mode, RVC Clean Mode, RVC Operational State, and Service Area on the endpoint 1.

@HunsupJung HunsupJung force-pushed the feature/updating-matter-rvc-ux branch from a5a6c42 to 97099e4 Compare September 2, 2025 09:40
@HunsupJung
Re-match profile to support Service Area
6cf2dfc 
Signed-off-by: HunsupJung <hunsup.jung@samsung.com>
@HunsupJung HunsupJung force-pushed the feature/updating-matter-rvc-ux branch from 97099e4 to 6cf2dfc Compare September 2, 2025 09:46
hcarter-775
hcarter-775 reviewed Sep 4, 2025
View reviewed changes
hcarter-775
hcarter-775 reviewed Sep 4, 2025
View reviewed changes
hcarter-775
hcarter-775 reviewed Sep 4, 2025
View reviewed changes
hcarter-775
hcarter-775 reviewed Sep 4, 2025
View reviewed changes
hcarter-775
hcarter-775 reviewed Sep 4, 2025
View reviewed changes
hcarter-775
hcarter-775 reviewed Sep 4, 2025
View reviewed changes
hcarter-775
hcarter-775 reviewed Sep 4, 2025
View reviewed changes
hcarter-775
hcarter-775 reviewed Sep 4, 2025
View reviewed changes
Copy link
Contributor

@hcarter-775 hcarter-775 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these are some initial comments/questions I have

hcarter-775
hcarter-775 reviewed Sep 4, 2025
View reviewed changes
nickolas-deboom
nickolas-deboom reviewed Sep 4, 2025
View reviewed changes
@HunsupJung
Update the PR by applying the reviews
0716447 
Signed-off-by: HunsupJung <hunsup.jung@samsung.com>
hcarter-775
hcarter-775 reviewed Sep 5, 2025
View reviewed changes
hcarter-775
hcarter-775 reviewed Sep 5, 2025
View reviewed changes
@HunsupJung
Modify find_default_endpoint
93942f6 
Signed-off-by: HunsupJung <hunsup.jung@samsung.com>
hcarter-775
hcarter-775 approved these changes Sep 10, 2025
View reviewed changes
Copy link
Contributor

@hcarter-775 hcarter-775 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hcarter-775 hcarter-775 hcarter-775 approved these changes

@nickolas-deboom nickolas-deboom nickolas-deboom approved these changes

@z-michel z-michel Awaiting requested review from z-michel

@tpmanley tpmanley Awaiting requested review from tpmanley

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HunsupJung @hcarter-775 @nickolas-deboom