Skip to content

Conversation

Fy-atto7
Copy link

@Fy-atto7 Fy-atto7 commented Sep 8, 2025

Check all that apply

Type of Change

  • WWST Certification Request
    • If this is your first time contributing code:
      • I have reviewed the README.md file
      • I have reviewed the CODE_OF_CONDUCT.md file
      • I have signed the CLA
    • I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
  • Bug fix
  • New feature
  • Refactor

Checklist

  • I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have verified my changes by testing with a device or have communicated a plan for testing
  • I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

Modify the profile name of the 720 air purifier in the fingerprints file.

Summary of Completed Tests

Tested on actual devices.

@ctowns ctowns requested a review from hcarter-775 September 8, 2025 18:53
@Huangxiangjie
Copy link
Contributor

Huangxiangjie commented Sep 11, 2025

Hi @ctowns and @hcarter-775
Could you help to merge this PR, thank you.

Copy link

Test Results

   69 files    449 suites   0s ⏱️
2 337 tests 2 337 ✅ 0 💤 0 ❌
3 930 runs  3 930 ✅ 0 💤 0 ❌

Results for commit 038486e.

Copy link

File Coverage
All files 91%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-thermostat/src/init.lua 91%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-thermostat/src/embedded-cluster-utils.lua 95%

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against 038486e

@ctowns
Copy link
Contributor

ctowns commented Sep 11, 2025

I moved these changes to this PR since there is an issue with the license agreement CI since this is coming from a public fork of the repo: #2390

Let's move forward with the other PR to get around the license agreement issue.

@Huangxiangjie
Copy link
Contributor

Thank you. The status with CLA is very strange. CLA has been signed in PR-2342 which is the first PR of Fy-atto7.
#2342 (comment)
We will close this PR.

@Fy-atto7 Fy-atto7 closed this Sep 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants