Fix: Remove continue-on-error from API tests in CI after fixing test …#143
Merged
Smartdevs17 merged 1 commit intoSmartdevs17:mainfrom Mar 27, 2026
Conversation
|
@devJaja is attempting to deploy a commit to the smartdevs17's projects Team on Vercel. A member of the Team first needs to authorize it. |
Owner
|
LGTM. Kindly drop a review. Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…failures
Summary
Removes the || echo "::warning::..." workaround from the API test step in CI, which was masking pre
-existing test failures and allowing broken code to be merged.
Changes
Why
All 14 previously failing API tests are now passing (81 total across 6 test suites). The workaround
is no longer needed and was actively preventing CI from enforcing test quality.
Testing
Test Suites: 6 passed, 6 total
Tests: 81 passed, 81 total
CI will now correctly fail and block merges when tests fail.
Closes: #59