Skip to content

docs(api): align examples with client-side signing flow#155

Merged
Smartdevs17 merged 2 commits intoSmartdevs17:mainfrom
OperaCode:fix/issue-88-validation
Mar 30, 2026
Merged

docs(api): align examples with client-side signing flow#155
Smartdevs17 merged 2 commits intoSmartdevs17:mainfrom
OperaCode:fix/issue-88-validation

Conversation

@OperaCode
Copy link
Copy Markdown
Contributor

Summary

  • update api/README.md to document the current prepare/sign/submit API flow
  • rewrite api/examples/usage.ts so it no longer sends userSecret to the server
  • add an explicit note that Stellar secret keys must remain client-side

Context

Issue #88 references Keypair.fromSecret() handling in api/src/services/stellar.service.ts, but that code path is no longer present on main after PR #102 was merged on March 23, 2026.

Related to #88

@vercel
Copy link
Copy Markdown

vercel bot commented Mar 28, 2026

@OperaCode is attempting to deploy a commit to the smartdevs17's projects Team on Vercel.

A member of the Team first needs to authorize it.

@drips-wave
Copy link
Copy Markdown

drips-wave bot commented Mar 28, 2026

Hey @OperaCode! 👋 It looks like this PR isn't linked to any issue.

If this PR is for one of the issues assigned to you as part of a Wave, please link it to ensure your contribution is tracked properly. You can do this by adding a keyword to the PR description (e.g., Closes #123), or by clicking a button below:

Issue Title
#88 Fix: Add missing error handling for Keypair.fromSecret() in API Link to this issue

ℹ️ Learn more about linking PRs to issues

@Smartdevs17 Smartdevs17 merged commit 3ca4c5f into Smartdevs17:main Mar 30, 2026
2 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants