Open
Conversation
Prevents Winsock Deprecated Warnings, which currently appear because of deprecated functions are in use and require `#define _WINSOCK_DEPRECATED_NO_WARNINGS`, I've also made `non_blocking` an unsigned long instead of an int, because Visual Studio 2017 is throwing a compiler error trying to convert an int * to a u_long *.
|
The define should be removed as the users need to know the functions being used are deprecated. |
I've made this have it's own Zed_Net define, which could eventually cover other platform(s) socket deprecation stuff!
Author
|
@Themperror I've made these an optional fix by adding a check for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevents Winsock Deprecated Warnings, which currently appear because of deprecated functions are in use and require
#define _WINSOCK_DEPRECATED_NO_WARNINGS, I've also madenon_blockingan unsigned long instead of an int, because Visual Studio 2017 is throwing a compiler error trying to convert an int * to a u_long *.