Skip to content

Add default notification email to kfp pipeline #406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kmontemayor2-sc wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add default notification email to kfp pipeline #406

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
49f652f
Add default notification email to kfp pipeline
kmonte Dec 2, 2025
f362046
Merge branch 'main' into kmonte/add-default-email
kmonte Dec 17, 2025
016e679
swap to using default sa email
kmonte Dec 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions python/gigl/orchestration/kubeflow/kfp_orchestrator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,18 +149,8 @@ def run(
"template_or_frozen_config_uri": task_config_uri.uri,
"resource_config_uri": resource_config_uri.uri,
}
# We need to provide *some* notification emails, other wise the cleanup component will fail.
# Ideally, we'd be able to provide None and have it handle it, but for whatever reason
# that's not supported atm. Passing in None gives the below error:
# Notification email "recipients" parameter must specify at least one recipient.
if notification_emails:
run_keyword_args["notification_emails"] = notification_emails
else:
run_keyword_args["notification_emails"] = [
get_resource_config(
resource_config_uri=resource_config_uri
).service_account_email
]
if stop_after is not None:
run_keyword_args["stop_after"] = stop_after

Expand Down
4 changes: 3 additions & 1 deletion python/gigl/orchestration/kubeflow/kfp_pipeline.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
from gigl.common import LocalUri
from gigl.common.logger import Logger
from gigl.common.types.resource_config import CommonPipelineComponentConfigs
from gigl.env.pipelines_config import get_resource_config
from gigl.orchestration.kubeflow.utils.glt_backend import (
check_glt_backend_eligibility_component,
)
Expand Down Expand Up @@ -247,7 +248,8 @@ def pipeline(
resource_config_uri: str,
start_at: str = GiGLComponents.ConfigPopulator.value,
stop_after: Optional[str] = None,
notification_emails: Optional[List[str]] = None,
# We need to provide *some* notification emails, other wise the cleanup component will fail.
notification_emails: List[str] = [get_resource_config().service_account_email],
Copy link
Collaborator

@svij-sc svij-sc Dec 18, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this also fix make compile_gigl_kubeflow_pipeline ?

Copy link
Collaborator Author

@kmontemayor2-sc kmontemayor2-sc Dec 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that issue is due to no pipeline path being provided, it's separate.

):
with kfp.dsl.ExitHandler(
VertexNotificationEmailOp(recipients=notification_emails),
Expand Down