Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .github/workflows/release-documentation.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ jobs:
# For importing to work, we have to make sure that your modules can be found by Sphinx and
# that dependencies can be resolved.
- name: Setup Machine for releasing documentation
uses: snapchat/gigl/.github/actions/setup-python-tools@main
uses: ./.github/actions/setup-python-tools
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we revert this?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will do this post PR merge along with the other similar changes.

Post PR merge we will need to update back ./.github/actions/setup-python-tools --> snapchat/gigl/.github/actions/setup-python-tools@main

with:
install_dev_deps: "true"
setup_gcloud: "true"
Expand All @@ -44,7 +44,8 @@ jobs:
# We also make gigl available w/ editable install `-e` so that autodoc can find it.
- name: Install necessary doc dependencies
run: |
uv sync --extra docs
uv sync --group docs --inexact
uv pip install -e .
- name: Sphinx build
run: |
make build_docs
Expand Down
1 change: 1 addition & 0 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,7 @@ dev = [
"pre-commit==3.3.2",
]
docs = [
"astroid==3.3.11", # Newer versions of astroid are not compatible with sphinx==7.4.7
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to lock this as newer versions seem incompatible with the sphinx autodoc version.

"sphinx==7.4.7",
"sphinx-rtd-theme==2.0.0",
"pydata-sphinx-theme==0.16.1",
Expand Down
5 changes: 0 additions & 5 deletions python/setup.py
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This removal is unrelated to this PR right?

Again, I really prefer to avoid these unrelated changes if possible.

Copy link
Collaborator Author

@svij-sc svij-sc Dec 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its releated as it was causing issues with build - i dunno why.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

weird!

This file was deleted.

10 changes: 7 additions & 3 deletions uv.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.