Skip to content

Conversation

@swong3-sc
Copy link
Collaborator

@swong3-sc swong3-sc commented Dec 19, 2025

Scope of work done

In the partition method of the DistPartitioner class, the following statement exists:
if self._node_feat is not None or self._node_labels is not None:

If this statement is false, the else block doesn't initialize partitioned_node_labels, and this causes a variable reference before assignment error when we try to return this value.

Where is the documentation for this feature?: N/A

Did you add automated tests or write a test plan?

No

Updated Changelog.md? NO

Ready for code review?: YES

Copy link
Collaborator

@mkolodner-sc mkolodner-sc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Sam!

Copy link
Collaborator

@kmontemayor2-sc kmontemayor2-sc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Good catch :) I wonder why this wasn't caught before...

@swong3-sc swong3-sc marked this pull request as ready for review December 20, 2025 00:09
@swong3-sc swong3-sc added this pull request to the merge queue Dec 20, 2025
Merged via the queue into main with commit 9140c10 Dec 20, 2025
6 checks passed
@swong3-sc swong3-sc deleted the swong3/dist_partitioner_node_label_bug branch December 20, 2025 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants