Skip to content

C codegen fixes #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
li-feng-sc merged 3 commits into from
Aug 26, 2025
Merged

C codegen fixes #203

li-feng-sc merged 3 commits into from
Aug 26, 2025

Conversation

@rFlex
Copy link

@rFlex rFlex commented Aug 26, 2025

This change fixes some issues I found while integrating the C codegen change.

  • Fixed enum not using the right translator when importing an enum from a yaml file.
  • Fixed DataRef and DataView translators not exposing their CppType and CType, causing compilation failures when wrapped in optionals or other boxed types
  • Fixed casing for future_c.h being inconsistent.

@li-feng-sc li-feng-sc merged commit f876056 into Snapchat:experimental-record Aug 26, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@li-feng-sc li-feng-sc li-feng-sc approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rFlex @li-feng-sc @scorsinsc