Open
Conversation
- Introduced `WebLinkSanitizer.kt` with functions to validate and sanitize HTTP/HTTPS URLs. - Added `toValidHttpUrlOrNull` for URL parsing and normalization. - Implemented `sanitizeHttpLinks` to filter and normalize a list of `WebLink` entries. - Created unit tests in `WebLinkSanitizerTest.kt` to ensure functionality and correctness of URL handling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: invalid / malformed URLs can leak into WebLink patching (Komga) and MangaDex ebookjapan URL had an extra brace.
Fix: add WebLinkSanitizer to validate/normalize http(s) links + apply in Komga adapter; add tests; fix ebookjapan URL formatting.
Behavior change: non-http(s) or hostless links are dropped (warn-logged).
addresses behavior noted in #272