-
Notifications
You must be signed in to change notification settings - Fork 1k
Update get-started-with-guides.md #2669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Note: The image uploads happen async, so they may not be uploaded yet if you click this quickly.. try again in a few minutes if so. |
|
Note: The image uploads happen async, so they may not be uploaded yet if you click this quickly.. try again in a few minutes if so. |
|
Note: The image uploads happen async, so they may not be uploaded yet if you click this quickly.. try again in a few minutes if so. |
|
Note: The image uploads happen async, so they may not be uploaded yet if you click this quickly.. try again in a few minutes if so. |
sfc-gh-annafilippova
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some questions/comments about layout and structure
| - [SFGuides on GitHub](https://github.com/Snowflake-Labs/sfguides) | ||
| - [Learn the GitHub Flow](https://guides.github.com/introduction/flow/) | ||
| - [Learn How to Fork a project on GitHub](https://guides.github.com/activities/forking/) | ||
| - Other relevant links to blogs, other guides, announcements etc. go here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you mean to add this? I don't think we want to replace two useful URLs with a non-specific message like this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seeing that you have these at the end now -- given that, does it make sense to have two related resources headings? Should this heading instead be something like "Get started quickly" or "If you prefer video instructions"... and then links to the two youtube videos?
I do think the github flow and forks are important pre-requisites so not sure if we want to relegate it to all the way at the bottom
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
when we preview the guide, the components of a guide section explains what basic layout details are needed:
- intro (what you will learn, build etc.)
- topics
- conclusion (what you learned, built etc.) <-- this is just to explain the basic layout... these are instructions.
our Guide conclusion is at the bottom where I mention all important links mentioned in our guide.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still think it's confusing to do this, and we should simplify
|
|
||
| #### Images | ||
|  | ||
|  |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't work for me 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sfc-gh-kkomail were you able to fix this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep working in preview link!
site/sfguides/src/get-started-with-guides/get-started-with-guides.md
Outdated
Show resolved
Hide resolved
|
|
||
| It's also important to remember that by the time a reader has completed a Guide, the goal is that they have actually built something! Guides teach through hands-on examples -- not just explaining concepts. | ||
|
|
||
| ### What We've Covered |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this be here? there's a similar section below
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
explaining components of a guide
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as above. it's confusing
|
|
||
|
|
||
|
|
||
| ### Conclusion & Next Steps |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this feels odd at the beginning of a document
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
explaining components of a guide
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still think this is confusing here
| ### Overview | ||
|
|
||
| Please use [this markdown file](site/sfguides/src/_markdown-template/) as a template for writing your own Snowflake Guides. This example guide has elements that you will use when writing your own guides, including: code snippet highlighting, downloading files, inserting photos, and more. | ||
| Please use [this markdown file](https://github.com/Snowflake-Labs/sfquickstarts/tree/master/site/sfguides/src#:~:text=_imports-,_markdown,-%2Dtemplate) as a template for writing your own Snowflake Guides. This example guide has elements that you will use when writing your own guides, including: code snippet highlighting, downloading files, inserting photos, and more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this link doesn't route me to the right spot
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these links still don't route for me so I think the path is the best way to direct folks here
|
|
||
| This section covers the basic markdown formatting options that you will need for your QuickStart. | ||
|
|
||
| Look at the [markdown source for this sfguide](https://github.com/Snowflake-Labs/sfquickstarts/blob/master/site/sfguides/src/_template/markdown.template) to see how to use markdown to generate code snippets, info boxes, and download buttons. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
getting a 404 error with the link
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this doesn't look like it was changed in this PR
updates per comments
|
Note: The image uploads happen async, so they may not be uploaded yet if you click this quickly.. try again in a few minutes if so. |
1 similar comment
|
Note: The image uploads happen async, so they may not be uploaded yet if you click this quickly.. try again in a few minutes if so. |
| #### Images | ||
|  | ||
|
|
||
|  |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is not valid markdown, so it doesn't work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this comment still needs to be addressed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
images are working fine in GitHub preview as well as staging links.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is what I see as the markdown format for images: 
if that addresses your comment @sfc-gh-annafilippova ?
|
Note: The image uploads happen async, so they may not be uploaded yet if you click this quickly.. try again in a few minutes if so. |
1 similar comment
|
Note: The image uploads happen async, so they may not be uploaded yet if you click this quickly.. try again in a few minutes if so. |
|
Note: The image uploads happen async, so they may not be uploaded yet if you click this quickly.. try again in a few minutes if so. |
|
Note: The image uploads happen async, so they may not be uploaded yet if you click this quickly.. try again in a few minutes if so. |
| It is important to set the correct metadata for your Snowflake Guide. The metadata contains all the information required for listing and publishing your guide and includes the following: | ||
|
|
||
| ```diff | ||
| - REQUIRED |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should keep the callout for required vs optional fields
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should also list what the github actions test for (I have these in the readme) and what they are doing (e.g., file rejected if action not met)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the required/optional fields are still there... the ```diff just makes them more prominent.
Adding the actions bit in
| } | ||
| ``` | ||
|
|
||
| #### Info Boxes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this part is slightly confusing to me -- I think we can remove since it's very specific. I wasn't sure what you meant by "pick messages above and use this code" because I didn't see code called out
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It had generic code, replaced with specific code since I have seen several Quickstarts use these types of callouts.
| #### Images | ||
|  | ||
|
|
||
|  |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this comment still needs to be addressed
|
Note: The image uploads happen async, so they may not be uploaded yet if you click this quickly.. try again in a few minutes if so. |
|
Note: The image uploads happen async, so they may not be uploaded yet if you click this quickly.. try again in a few minutes if so. |
|
Note: The image uploads happen async, so they may not be uploaded yet if you click this quickly.. try again in a few minutes if so. |
|
Note: The image uploads happen async, so they may not be uploaded yet if you click this quickly.. try again in a few minutes if so. |
sfc-gh-ridasafdar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approving so we can merge and I'll make updates to markdwon directly
| this means that actual code needs to be included (not just pseudo-code or concepts). | ||
| There are three main sub-headers in a Conclusion step: | ||
| ### Prerequisites |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if adding the h1/h2/h3 considerations here is better next to each section because the number of # varies in this and can be confusing
| ``` | ||
| > Adding an Info Box: | ||
| > Pick the messages above and use this code. This will appear as an info box. | ||
| > [!NOTE] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this and the callout to these in the boxes above is slightly repetitive. Let's simplify and have them in one section where we say add [!NOTE], [!TIP] [!IMPORTANT] to the start of a markdown line where you want to flag something to the user.
let's leaving out warning and caution - I don't think they're needed
| #### Images | ||
|  | ||
|
|
||
|  |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is what I see as the markdown format for images: 
if that addresses your comment @sfc-gh-annafilippova ?
|  | ||
|
|
||
|
|
||
| Please DO NOT use HTML code for adding images. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could we put this in the blue box format you have?
Please DO NOT use HTML code for adding images.
dismissing so I can make markdown updates directly

No description provided.