Skip to content

Conversation

@sfc-gh-kkomail
Copy link
Collaborator

No description provided.

@snowflake-github-workato
Copy link

https://publish-p57963-e462098.adobeaemcloud.com/en/developers/guides/get-started-with-guides-ce5b6a9d24a1b98a06d0f63b021c5913c811cada

Note: The image uploads happen async, so they may not be uploaded yet if you click this quickly.. try again in a few minutes if so.

@snowflake-github-workato
Copy link

https://publish-p57963-e462098.adobeaemcloud.com/en/developers/guides/get-started-with-guides-e19e3108b7826f42674d4c73d8b7fb4e8ddb22c7

Note: The image uploads happen async, so they may not be uploaded yet if you click this quickly.. try again in a few minutes if so.

@snowflake-github-workato
Copy link

https://publish-p57963-e462098.adobeaemcloud.com/en/developers/guides/get-started-with-guides-6837d59c15dfb232ac4179e8d7130d0a2530a828

Note: The image uploads happen async, so they may not be uploaded yet if you click this quickly.. try again in a few minutes if so.

@snowflake-github-workato
Copy link

https://publish-p57963-e462098.adobeaemcloud.com/en/developers/guides/get-started-with-guides-6837d59c15dfb232ac4179e8d7130d0a2530a828

Note: The image uploads happen async, so they may not be uploaded yet if you click this quickly.. try again in a few minutes if so.

Copy link
Contributor

@sfc-gh-annafilippova sfc-gh-annafilippova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some questions/comments about layout and structure

- [SFGuides on GitHub](https://github.com/Snowflake-Labs/sfguides)
- [Learn the GitHub Flow](https://guides.github.com/introduction/flow/)
- [Learn How to Fork a project on GitHub](https://guides.github.com/activities/forking/)
- Other relevant links to blogs, other guides, announcements etc. go here
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean to add this? I don't think we want to replace two useful URLs with a non-specific message like this

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seeing that you have these at the end now -- given that, does it make sense to have two related resources headings? Should this heading instead be something like "Get started quickly" or "If you prefer video instructions"... and then links to the two youtube videos?

I do think the github flow and forks are important pre-requisites so not sure if we want to relegate it to all the way at the bottom

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when we preview the guide, the components of a guide section explains what basic layout details are needed:

  • intro (what you will learn, build etc.)
  • topics
  • conclusion (what you learned, built etc.) <-- this is just to explain the basic layout... these are instructions.

our Guide conclusion is at the bottom where I mention all important links mentioned in our guide.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still think it's confusing to do this, and we should simplify


#### Images
![Puppy](assets/puppy.jpg)
![](assets/puppy.jpg "Puppy")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't work for me 🤔

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sfc-gh-kkomail were you able to fix this?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep working in preview link!


It's also important to remember that by the time a reader has completed a Guide, the goal is that they have actually built something! Guides teach through hands-on examples -- not just explaining concepts.

### What We've Covered
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be here? there's a similar section below

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

explaining components of a guide

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above. it's confusing




### Conclusion & Next Steps
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this feels odd at the beginning of a document

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

explaining components of a guide

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still think this is confusing here

### Overview

Please use [this markdown file](site/sfguides/src/_markdown-template/) as a template for writing your own Snowflake Guides. This example guide has elements that you will use when writing your own guides, including: code snippet highlighting, downloading files, inserting photos, and more.
Please use [this markdown file](https://github.com/Snowflake-Labs/sfquickstarts/tree/master/site/sfguides/src#:~:text=_imports-,_markdown,-%2Dtemplate) as a template for writing your own Snowflake Guides. This example guide has elements that you will use when writing your own guides, including: code snippet highlighting, downloading files, inserting photos, and more.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this link doesn't route me to the right spot

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these links still don't route for me so I think the path is the best way to direct folks here


This section covers the basic markdown formatting options that you will need for your QuickStart.

Look at the [markdown source for this sfguide](https://github.com/Snowflake-Labs/sfquickstarts/blob/master/site/sfguides/src/_template/markdown.template) to see how to use markdown to generate code snippets, info boxes, and download buttons.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getting a 404 error with the link

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this doesn't look like it was changed in this PR

updates per comments
@snowflake-github-workato
Copy link

https://publish-p57963-e462098.adobeaemcloud.com/en/developers/guides/get-started-with-guides-b8f316b8bac54e78e1a250237176032bc415693e

Note: The image uploads happen async, so they may not be uploaded yet if you click this quickly.. try again in a few minutes if so.

1 similar comment
@snowflake-github-workato
Copy link

https://publish-p57963-e462098.adobeaemcloud.com/en/developers/guides/get-started-with-guides-b8f316b8bac54e78e1a250237176032bc415693e

Note: The image uploads happen async, so they may not be uploaded yet if you click this quickly.. try again in a few minutes if so.

#### Images
![Puppy](assets/puppy.jpg)

![](assets/puppy.jpg "Cute Puppy")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not valid markdown, so it doesn't work

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this comment still needs to be addressed

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

images are working fine in GitHub preview as well as staging links.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is what I see as the markdown format for images: Alt text

so maybe we update this to: puppy

if that addresses your comment @sfc-gh-annafilippova ?

@snowflake-github-workato
Copy link

https://publish-p57963-e462098.adobeaemcloud.com/en/developers/guides/get-started-with-guides-32259413ab326837dfc1fef02256239339ca5155

Note: The image uploads happen async, so they may not be uploaded yet if you click this quickly.. try again in a few minutes if so.

1 similar comment
@snowflake-github-workato
Copy link

https://publish-p57963-e462098.adobeaemcloud.com/en/developers/guides/get-started-with-guides-32259413ab326837dfc1fef02256239339ca5155

Note: The image uploads happen async, so they may not be uploaded yet if you click this quickly.. try again in a few minutes if so.

@snowflake-github-workato
Copy link

https://publish-p57963-e462098.adobeaemcloud.com/en/developers/guides/get-started-with-guides-99c04ac3a8f796a9457042694b42c5b28a77671f

Note: The image uploads happen async, so they may not be uploaded yet if you click this quickly.. try again in a few minutes if so.

@snowflake-github-workato
Copy link

https://publish-p57963-e462098.adobeaemcloud.com/en/developers/guides/get-started-with-guides-8c9cc5ffced62e81f56f83a66e670df6deb5aa29

Note: The image uploads happen async, so they may not be uploaded yet if you click this quickly.. try again in a few minutes if so.

It is important to set the correct metadata for your Snowflake Guide. The metadata contains all the information required for listing and publishing your guide and includes the following:

```diff
- REQUIRED
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should keep the callout for required vs optional fields

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should also list what the github actions test for (I have these in the readme) and what they are doing (e.g., file rejected if action not met)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the required/optional fields are still there... the ```diff just makes them more prominent.

Adding the actions bit in

}
```

#### Info Boxes
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this part is slightly confusing to me -- I think we can remove since it's very specific. I wasn't sure what you meant by "pick messages above and use this code" because I didn't see code called out

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It had generic code, replaced with specific code since I have seen several Quickstarts use these types of callouts.

#### Images
![Puppy](assets/puppy.jpg)

![](assets/puppy.jpg "Cute Puppy")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this comment still needs to be addressed

@snowflake-github-workato
Copy link

https://publish-p57963-e462098.adobeaemcloud.com/en/developers/guides/get-started-with-guides-17a4aca22478686afdc2ec51f9735eb115c4d2e1

Note: The image uploads happen async, so they may not be uploaded yet if you click this quickly.. try again in a few minutes if so.

@snowflake-github-workato
Copy link

https://publish-p57963-e462098.adobeaemcloud.com/en/developers/guides/get-started-with-guides-70cd92302b042925541c963dfe091b1d3057ad06

Note: The image uploads happen async, so they may not be uploaded yet if you click this quickly.. try again in a few minutes if so.

@snowflake-github-workato
Copy link

https://publish-p57963-e462098.adobeaemcloud.com/en/developers/guides/get-started-with-guides-bf87a444c919943e4b8ba1643c125e048b42f834

Note: The image uploads happen async, so they may not be uploaded yet if you click this quickly.. try again in a few minutes if so.

@snowflake-github-workato
Copy link

https://publish-p57963-e462098.adobeaemcloud.com/en/developers/guides/get-started-with-guides-58c42f966fef0122b97c62cca17d2995faa135a8

Note: The image uploads happen async, so they may not be uploaded yet if you click this quickly.. try again in a few minutes if so.

Copy link
Collaborator

@sfc-gh-ridasafdar sfc-gh-ridasafdar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving so we can merge and I'll make updates to markdwon directly

this means that actual code needs to be included (not just pseudo-code or concepts).
There are three main sub-headers in a Conclusion step:
### Prerequisites
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if adding the h1/h2/h3 considerations here is better next to each section because the number of # varies in this and can be confusing

```
> Adding an Info Box:
> Pick the messages above and use this code. This will appear as an info box.
> [!NOTE]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this and the callout to these in the boxes above is slightly repetitive. Let's simplify and have them in one section where we say add [!NOTE], [!TIP] [!IMPORTANT] to the start of a markdown line where you want to flag something to the user.

let's leaving out warning and caution - I don't think they're needed

#### Images
![Puppy](assets/puppy.jpg)

![](assets/puppy.jpg "Cute Puppy")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is what I see as the markdown format for images: Alt text

so maybe we update this to: puppy

if that addresses your comment @sfc-gh-annafilippova ?

![](assets/puppy.jpg "Cute Puppy")


Please DO NOT use HTML code for adding images.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we put this in the blue box format you have?

Please DO NOT use HTML code for adding images.

@sfc-gh-ridasafdar sfc-gh-ridasafdar dismissed sfc-gh-annafilippova’s stale review November 21, 2025 20:16

dismissing so I can make markdown updates directly

@sfc-gh-kkomail sfc-gh-kkomail merged commit 88ca10d into master Nov 21, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants