Sync beefy commitment on demand#1217
Merged
vgeddes merged 10 commits intovincent/beefy-relay-improvementsfrom Jun 3, 2024
Merged
Sync beefy commitment on demand#1217vgeddes merged 10 commits intovincent/beefy-relay-improvementsfrom
vgeddes merged 10 commits intovincent/beefy-relay-improvementsfrom
Conversation
vgeddes
reviewed
May 31, 2024
Collaborator
|
Still need to adjust for the change in Only submissions for mandatory commitments need to include an MMR leaf and proof. The one-shot relay doesn't need to include those. |
Contributor
Author
I'd prefer to include the MMR leaf and proof for the oneshot case, vaguely recalled it won't cost much to add these to calldata without validation. The benefit is that it's possible to use the oneshot command for even sync the mandatory commitments. |
vgeddes
approved these changes
Jun 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A one-shot relayer at this moment and how we would integrate the one-shot relayer in future as follows from @vgeddes: