Dry-run the entire InboundMessage by yrong · Pull Request #1676 · Snowfork/snowbridge

yrong · 2026-01-18T04:29:34Z

Context

Revamp the external v2_dispatch function to allow the UI to dry-run the entire message instead of each individual command.

codecov · 2026-01-18T04:30:48Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.04%. Comparing base (8b31be0) to head (504bb85).
⚠️ Report is 8 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1676      +/-   ##
==========================================
- Coverage   81.20%   81.04%   -0.16%     
==========================================
  Files          22       22              
  Lines        1016      997      -19     
  Branches      196      186      -10     
==========================================
- Hits          825      808      -17     
+ Misses        174      172       -2     
  Partials       17       17

Flag	Coverage Δ
solidity	`81.04% <100.00%> (-0.16%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Initial plan * Fix dispatchSuccess initialization to false Co-authored-by: yrong <4383920+yrong@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: yrong <4383920+yrong@users.noreply.github.com>

* Initial plan * Remove extra blank line for consistency Co-authored-by: yrong <4383920+yrong@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: yrong <4383920+yrong@users.noreply.github.com>

* Initial plan * Implement Option A: Propagate InsufficientGasLimit from v2_dispatch Co-authored-by: yrong <4383920+yrong@users.noreply.github.com> * Simplify InsufficientGasLimit rethrow logic Co-authored-by: yrong <4383920+yrong@users.noreply.github.com> * Fix tests --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: yrong <4383920+yrong@users.noreply.github.com> Co-authored-by: ron <yrong1997@gmail.com>

…sion (#1690) * Initial plan * Fix: Check atomic flag before emitting CommandFailed event Co-authored-by: yrong <4383920+yrong@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: yrong <4383920+yrong@users.noreply.github.com>

yrong · 2026-01-27T09:39:51Z

contracts/src/Gateway.sol

-
+    // independently, such that failures emit a `CommandFailed` event without stopping execution of
+    // subsequent commands. Returns true if all commands executed successfully, false if any command failed.
+    function v2_dispatch(InboundMessageV2 calldata message) external onlySelf returns (bool) {


The UI can dry-run this method against the entire InboundMessageV2 message, which is especially useful when we extend use cases to messages composed of multiple calls or commands, such as in the L2 integration.

How can it do though if this function is secured by onlySelf? Can eth_estimateGas simulate a fake origin?

Correct. Both eth_call and eth_estimateGas can and they do not require signature.

{ "jsonrpc": "2.0", "method": "eth_estimateGas", "params": [ { "from": "0xYourSenderAddressHere", "to": "0xTargetContractAddress", "data": "0x..." } ], "id": 1 }

E.g. from our api:

snowbridge/web/packages/operations/src/register_erc20.ts

Lines 34 to 40 in 06c4491

const tx = await gateway.getFunction("registerToken").populateTransaction(TOKEN_CONTRACT, {

value: ethers.parseEther("1"),

from: ETHEREUM_ACCOUNT_PUBLIC,

})

console.log("Plan tx:", tx)

console.log("Plan gas:", await context.ethereum().estimateGas(tx))

console.log("Plan dry run:", await context.ethereum().call(tx))

claravanstaden

Probably needs a re-audit. I can ask to audit this together with the L2 contracts?

vgeddes · 2026-02-04T11:58:05Z

contracts/src/Gateway.sol


-        return allCommandsSucceeded;
+    // Helper function to dispatch a single command with try-catch for error handling
+    function v2_dispatchCommand(CommandV2 calldata command, bytes32 origin) external onlySelf {


I think we can perform more refactoring to remove all the intermediate internal calls.

v2_dispatchCommand could call HandlersV2.unlockNativeToken directly, and so on?

vgeddes · 2026-02-04T12:02:03Z

contracts/src/Gateway.sol

+        } catch (bytes memory reason) {
+            // If insufficient gas limit, rethrow the error to stop processing
+            // Otherwise, silently ignore command failures
+            if (reason.length >= 4 && bytes4(reason) == IGatewayV2.InsufficientGasLimit.selector) {


Not a fan of using Solidity's somewhat awkward exceptions as a control flow mechanism. They are a bit half-baked.

Like in golang, could v2_dispatch return (bool insufficientGas, bool _success)?

vgeddes · 2026-02-04T12:16:56Z

contracts/src/Gateway.sol

-
+    // independently, such that failures emit a `CommandFailed` event without stopping execution of
+    // subsequent commands. Returns true if all commands executed successfully, false if any command failed.
+    function v2_dispatch(InboundMessageV2 calldata message) external onlySelf returns (bool) {


Its also a bit awkward that InboundMessageV2 is built by BridgeHub, and contains fields such as nonce and origin which are irrelevant for dry-running. It means the UI needs to fake those.

Consider this alternative signature:

function v2_dispatch(Command[] calldata commands) returns ( bool insufficientGasLimit, bool failed, uint256 failureIndex )

Then the UI only needs to format commands. The parent for v2_dispatch can interpret the return values to set the final error state.

1fa3437#diff-74470ba8f35b42dbc8805739e92708c0696343e0b1819feb3e7a5ebb77cc623c

@vgeddes I made further refactoring based on your suggestion. However, the failureIndex output, as mentioned above, is not suitable, as multiple commands may fail. Additionally, for the input parameters, the nonce is required when emitting IGatewayV2.CommandFailed(nonce, i), and origin is necessary for calling contracts.

The updated dry-run function signature is as follows:

function v2_dispatch(CommandV2[] calldata commands, bytes32 origin, uint64 nonce) external onlySelf returns (bool insufficientGasLimit, bool success)

Let me know if you'd like to make further adjustments.

…k/snowbridge into ron/multi-contract-calls

…act-calls

yrong added 2 commits January 18, 2026 02:53

Multiple calls support

6a68f59

Support multiple calls

457e275

github-actions bot added the Component: Ethereum label Jan 18, 2026

Add test

a6c84ed

yrong requested a review from Copilot January 18, 2026 06:42

Copilot started reviewing on behalf of yrong January 18, 2026 06:42 View session

This comment was marked as off-topic.

Sign in to view

yrong and others added 4 commits January 18, 2026 11:45

Revamp test

d19ad8e

Improve L1 adapter

71cbe16

Harden L1 adapter

07cd880

Update contracts/src/AgentExecutor.sol

6c34fd5

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

yrong changed the title ~~Support multi contract calls~~ Support multiple contract calls Jan 19, 2026

yrong added 3 commits January 26, 2026 17:30

Merge branch 'main' into ron/multi-contract-calls

09b8b9e

Revert L2 changes

6ef87ff

Add atomic flag

f418da7

yrong requested a review from Copilot January 26, 2026 11:34

Copilot started reviewing on behalf of yrong January 26, 2026 11:34 View session

This comment was marked as outdated.

Sign in to view

This was referenced Jan 26, 2026

Fix dispatchSuccess initialization in Gateway.v2_submit #1685

Merged

Remove trailing blank line in GatewayV2.t.sol #1686

Merged

Fix dispatch logic, gas metering, and error handling in Gateway v2 #1687

Closed

Copilot AI and others added 2 commits January 26, 2026 20:54

Copilot AI mentioned this pull request Jan 26, 2026

Propagate InsufficientGasLimit errors from v2_dispatch #1688

Merged

yrong changed the title ~~Support multiple contract calls~~ Enhance atomic execution for v2 calls Jan 26, 2026

Copilot AI and others added 2 commits January 27, 2026 00:31

Fix tests

daead2b

Snowfork deleted a comment from Copilot AI Jan 27, 2026

Copilot AI and others added 3 commits January 27, 2026 13:19

More tests

22033e8

Improve test

1566ffb

yrong marked this pull request as ready for review January 27, 2026 06:27

yrong added 2 commits January 27, 2026 14:45

Improve AtomicCommandFailed error

f094137

Remove the atomic control in Comand

3c99e2a

yrong commented Jan 27, 2026

View reviewed changes

Move multi-call out

9d8fa86

yrong changed the title ~~Enhance atomic execution for v2 calls~~ Dry-run the entire InboundMessage Jan 27, 2026

yrong added 5 commits January 28, 2026 00:50

Revert change

6a44e06

Revert change

e50bc6a

Revert change

ead7af0

Restore the comments

e22e220

Revamp tests

de8ee09

yrong requested review from alistair-singh, claravanstaden and vgeddes January 27, 2026 17:27

Snowfork deleted a comment from Copilot AI Jan 27, 2026

claravanstaden approved these changes Feb 4, 2026

View reviewed changes

vgeddes reviewed Feb 4, 2026

View reviewed changes

yrong added 5 commits February 5, 2026 01:24

Refactor Gateway

1fa3437

Fix tests

88e5362

Merge branch 'ron/multi-contract-calls' of https://github.com/Snowfor…

d6590c8

…k/snowbridge into ron/multi-contract-calls

Merge branch 'ron/multi-contract-calls-revamped' into ron/multi-contr…

04bb804

…act-calls

Comments

a42f979

yrong requested a review from vgeddes February 5, 2026 01:59

Fix mock

504bb85

vgeddes approved these changes Feb 5, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Dry-run the entire InboundMessage#1676

Dry-run the entire InboundMessage#1676
yrong wants to merge 31 commits intomainfrom
ron/multi-contract-calls

yrong commented Jan 18, 2026 •

edited

Loading

Uh oh!

codecov bot commented Jan 18, 2026 •

edited

Loading

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as outdated.

Uh oh!

yrong Jan 27, 2026 •

edited

Loading

Uh oh!

vgeddes Feb 4, 2026

Uh oh!

alistair-singh Feb 4, 2026 •

edited

Loading

Uh oh!

claravanstaden left a comment

Uh oh!

vgeddes Feb 4, 2026

Uh oh!

vgeddes Feb 4, 2026 •

edited

Loading

Uh oh!

vgeddes Feb 4, 2026 •

edited

Loading

Uh oh!

yrong Feb 4, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

	const tx = await gateway.getFunction("registerToken").populateTransaction(TOKEN_CONTRACT, {
	value: ethers.parseEther("1"),
	from: ETHEREUM_ACCOUNT_PUBLIC,
	})
	console.log("Plan tx:", tx)
	console.log("Plan gas:", await context.ethereum().estimateGas(tx))
	console.log("Plan dry run:", await context.ethereum().call(tx))

Conversation

yrong commented Jan 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Context

Uh oh!

codecov bot commented Jan 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as outdated.

Uh oh!

yrong Jan 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vgeddes Feb 4, 2026

Choose a reason for hiding this comment

Uh oh!

alistair-singh Feb 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

claravanstaden left a comment

Choose a reason for hiding this comment

Uh oh!

vgeddes Feb 4, 2026

Choose a reason for hiding this comment

Uh oh!

vgeddes Feb 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vgeddes Feb 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

yrong Feb 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

yrong commented Jan 18, 2026 •

edited

Loading

codecov bot commented Jan 18, 2026 •

edited

Loading

yrong Jan 27, 2026 •

edited

Loading

alistair-singh Feb 4, 2026 •

edited

Loading

vgeddes Feb 4, 2026 •

edited

Loading

vgeddes Feb 4, 2026 •

edited

Loading

yrong Feb 4, 2026 •

edited

Loading