Open
Conversation
# Conflicts: # web/packages/test/scripts/build-binary.sh
# Conflicts: # relayer/relays/parachain/config.go
claravanstaden
force-pushed
the
clara/test-relayers
branch
from
7e73bc2 to
e739068
Compare
- Add UnmarshalSSZLiteFulu for Fulu beacon states - Add hashProposerLookahead for ProposerLookahead field (field 37) - Add debug logging to compare full vs lite tree roots for Fulu Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
yrong
reviewed
Feb 3, 2026
| Endpoint string `mapstructure:"endpoint"` | ||
| StateServiceEndpoint string `mapstructure:"stateServiceEndpoint"` | ||
| Spec SpecSettings `mapstructure:"spec"` | ||
| DataStore DataStore `mapstructure:"datastore"` |
Contributor
There was a problem hiding this comment.
If I understand correctly, DataStore is only required for the beacon-state service?
If that's the case, I suggest removing it here and instead adding the BeaconStateConfig, which is specific to the state service.
type Config struct {
Beacon beaconconf.BeaconConfig `mapstructure:"beacon"`
DataStore DataStore `mapstructure:"datastore"`
...
yrong
reviewed
Feb 3, 2026
Comment on lines
+85
to
+97
| func (b BeaconConfig) ValidateForStateService() error { | ||
| if err := b.validateCommon(); err != nil { | ||
| return err | ||
| } | ||
| // data store is required for beacon state service | ||
| if b.DataStore.Location == "" { | ||
| return errors.New("source beacon datastore [location] is not set") | ||
| } | ||
| if b.DataStore.MaxEntries == 0 { | ||
| return errors.New("source beacon datastore [maxEntries] is not set") | ||
| } | ||
| return nil | ||
| } |
Contributor
There was a problem hiding this comment.
Then this check can also be moved to state service.
yrong
reviewed
Feb 3, 2026
yrong
reviewed
Feb 3, 2026
yrong
reviewed
Feb 3, 2026
yrong
reviewed
Feb 3, 2026
yrong
reviewed
Feb 4, 2026
yrong
reviewed
Feb 4, 2026
yrong
reviewed
Feb 4, 2026
Contributor
Author
|
Tested all relayers on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.