Conversation
|
As raised by the CI, the |
alxbilger
left a comment
alxbilger
left a comment
There was a problem hiding this comment.
I don't understand how the CI installs proxqp...
.github/workflows/ci.yml
Outdated
| if [[ "${{ matrix.qp_solver }}" == "proxqp" ]]; then | ||
| cmake_options="$cmake_options \ | ||
| -DSOFTROBOTSINVERSE_ENABLE_PROXQP=ON \ | ||
| -DSOFA_ALLOW_FETCH_DEPENDENCIES=ON \ |
There was a problem hiding this comment.
| -DSOFA_ALLOW_FETCH_DEPENDENCIES=ON \ | |
| -DSOFA_ALLOW_FETCH_DEPENDENCIES=ON \ |
Still needed?
It does not yet, still working on the PR as it is a draft |
olivier-roussel
force-pushed
the
fix-proxsuite-support
branch
3 times, most recently
from
9728e6c to
c493597
Compare
olivier-roussel
force-pushed
the
fix-proxsuite-support
branch
from
c493597 to
86090aa
Compare
|
@alxbilger @EulalieCoevoet Does the PR looks OK to you for merging ? |
| message(FATAL_ERROR "Sofa.SoftRobots.Inverse: DEPENDENCY proxsuite NOT FOUND. SOFA_ALLOW_FETCH_DEPENDENCIES is OFF and thus cannot be fetched. Install proxsuite, or enable SOFA_ALLOW_FETCH_DEPENDENCIES to fix this issue.") | ||
| endif() | ||
| find_package(proxsuite REQUIRED) | ||
| message("Sofa.SoftRobots.Inverse: proxsuite FOUND. Will build with proxsuite support.") |
There was a problem hiding this comment.
Maybe you should keep:
if(proxsuite_FOUND)
message("Sofa.SoftRobots.Inverse: proxsuite FOUND. Will build with proxsuite support.")
else
message("Sofa.SoftRobots.Inverse: DEPENDENCY proxsuite NOT FOUND.")
There was a problem hiding this comment.
To have a verbose output if proxsuite not found ?
Because that was the purpose of having REQUIRED dependency here: if not found, it fails with error complaining about missing proxsuite dependency. So I think this message would be redundant here, no ?
There was a problem hiding this comment.
Okay I see. Good for me then.
3 participants
Fetch_contentsupport forproxsuite(see comment below). Restrict usage as external dependency only, with a cmake option to enableproxQPsupport.Enable: Requires conda-based CI first (see Adds a conda based CI workflow #53). Adding a CI withproxQPsupport on CIproxQPsolver enabled will be handled in another PR.