xmaslecture v1 Tim Nolle #4
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed Int to Double to be able to calculate the divisions correctly
tthuem
reviewed
Oct 1, 2021
Member
tthuem
left a comment
tthuem
left a comment
There was a problem hiding this comment.
Looks good to me. Only a minor comment.
| @@ -1,3 +1,5 @@ | |||
| ProfCalculator/.classpath | |||
| .project | |||
Member
There was a problem hiding this comment.
Probably not a got idea to ignore these files. These are needed for others to import the project.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added subtraction and division to the calculator, currently working on a switch between evaluation and brackets, but its still WiP. When its done it will be pushed to this branch as well.