Fix Parsing d-DNNFs Resulting in Boolean Root Nodes #90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A true or false d-DNNF could previously result in an empty graph, leading to panics during processing. Now, chain deletions replace a chain instead of fully removing it. Additionally, root nodes are not removed, even when they are true or false.
Boolean nodes previously led to panics, although they are valid for root nodes (only). These are now handled by a simple cnf with model count 0 (false) or 1 (true).
uulm-janbaudisch
changed the title
uulm-janbaudisch
force-pushed
the
fix-parser
branch
from
8c0cb47 to
c5f9f5e
Compare
As boolean nodes are removed as a node type. Instead, the attribute `kind` specifies whether the d-DNNF is a normal one without boolean nodes or a special case. A special d-DNNF is either a tautology (true root node) or contradiction (false root node).
uulm-janbaudisch
force-pushed
the
fix-parser
branch
from
c5f9f5e to
ae0a8fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
True and false nodes are now prevented from deletion when they are root nodes. Additionally, the tseitin transformation now allows for boolean root nodes.
Fixes #86.
Fixes #63.