Interview Coding Challenge Submission - Joseph M. Fallecker#55
Open
jmfallecker wants to merge 32 commits intoSoftWriters:masterfrom
jmfallecker:master
Open
Interview Coding Challenge Submission - Joseph M. Fallecker#55jmfallecker wants to merge 32 commits intoSoftWriters:masterfrom jmfallecker:master
jmfallecker wants to merge 32 commits intoSoftWriters:masterfrom
jmfallecker:master
Conversation
…del details to simplify a bit for later usage
…s layer to get the actual System datatype before sending to the database
…o create the database, tables and insert restaurant proc
…response is not correct quite yet. Pushing to break for lunch.
… method Ok(object) did not like serializing wrapped F# types, so added 'unwrap' methods to the domain objects, still enforcing that they can only be created if going through the domain type itself
…pologies there. Also added my thoughts on this as I am coding... things always tend to sprawl after developing something of any size
… testing and realized a missed requirement, so added ability to Get Reviews By User
…feel better since code is so cold and doesn't explain why things are structured the way they are. I swear I usually write way better commit messages, if you are actually reading this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
Thank you for the opportunity to interview and attempt this challenge, I really enjoyed talking to both Judson and Robert.
Please execute the SQL scripts in order of their prefix-number ascending and update the connection string in the appSettings.json file to point to your instance of the database.
I included "CommentsFromAuthor.txt" file for a bit of explanation of approach as well as testing strategy; it is free-form and not-terribly-formal.
Looking forward to hearing feedback from you, and I am hoping to move forward to any further steps with Softwriters, the portrayal of the culture that I've gotten from everyone is really exciting.
Thanks,
Joe Fallecker