Fix crash when a client sends empty fields#20
Open
cheapie wants to merge 1 commit intoSokomine:masterfrom
Open
Fix crash when a client sends empty fields#20cheapie wants to merge 1 commit intoSokomine:masterfrom
cheapie wants to merge 1 commit intoSokomine:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #18
This prevents the server from crashing if a locked node receives fields where "locks_sent_lock_command" is nil. This seems to happen occasionally with some clients for reasons I have not yet identified. I suspect it has something to do with the user doing something "invalid" for the current page and may even involve a race condition, but... regardless, this just changes it so that if nothing was sent for it to do then it just doesn't do anything.
As a side note, the "locks_sent_lock_command" field doesn't seem to ever actually be used, but I left the code for handing it in place as I'm assuming there's some reason behind it.