Open
Conversation
Contributor
Author
|
I just updated this PR with a refactor for Bots still randomly get stuck, but it's relatively uncommon. They also will now travel to the end of incomplete paths to extracts (which is expected to happen with Unity's limitations), wait ~10s, and then search for another extract. While this isn't ideal, it keeps them moving across the map to make raids more interesting. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mostly fixes bot extraction that was broken again with one of the 4.1.x updates.
There is a strange race condition sometimes causing bots to be unable to path to their extraction points, and I can't figure out what's causing it. It looks like
TriggerNewMove()initializes a new path for the bot, which clearsCancelRequested. Immediately after this happens,CanProceedWithPath()returns false becauseCancelRequestedis true, even thoughCancel()didn't appear to run first. I have no idea what else might be settingCancelRequestedto true. My only guess is thatClearCachedData()is running in parallel withTickPath(), but I'm not sure how the pathfinder is supposed to work. Here's an excerpt of what's happening:Fortunately, 90% of bots seem to be extracting without issues, so maybe this isn't such a big deal.