adds check for remove from playlist flag#6
Closed
jasonhamilton wants to merge 4 commits intoSolidEva:masterfrom
Closed
adds check for remove from playlist flag#6jasonhamilton wants to merge 4 commits intoSolidEva:masterfrom
jasonhamilton wants to merge 4 commits intoSolidEva:masterfrom
Conversation
Author
|
Adds functionality to make the software more extensible.
|
|
Please accept this pull request! @SolidHal otherwise, playlists are emptied by default! |
Owner
|
Closing this pull request, reference my comment on: #23 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the remove from playlist setting arg is set to false the software still tries to remove from playlist. It looks like when the previous method was deprecated a flag check was forgotten, so the software always tries to remove from playlist.