ECHOES-1009 Add Accordion Element #549
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for echoes-react ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
hashicorp-vault-sonar-prod
bot
changed the title
subdavis
force-pushed
the
bd/feature/add-Accordion-Element
branch
from
44688b0 to
0be8fdd
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ECHOES-1009
There are a number of problems with the legacy design system accordion that have been blocking me on other work. Rather than fix them, I thought it would be more helpful to get this new component in Echoes.
Accordion element
This is a very simple HTML native accordion using
<details>. It is fully accessible by default and does not require additional ARIA tags. It already complies with the ARIA spec.Style
The
<Accordion>on cloud and server have 2 different designs and quite different implementations. I decided to make this a simple least-common-denominator that should work for both. It has no hover/focus style.Behavior
It implements 2-direction binding so that it can be controlled externally, but also behaves correctly when
isOpenis not used.I'm happy to make any updates to this.