Skip to content

fix(tracker): 🐛 Rename 'distribution' to 'samples' in AimTracker for API compatibility #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SongshGeo merged 1 commit into from
Jan 17, 2026
Merged

fix(tracker): 🐛 Rename 'distribution' to 'samples' in AimTracker for API compatibility #146

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions abses/utils/tracker/aim_tracker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ def log_agent_vars(
self._run.track(numeric_series.iloc[0], name=metric_name, step=step)
else:
dist = Distribution(
distribution=numeric_series, bin_count=self._bin_count
samples=numeric_series, bin_count=self._bin_count
)
self._run.track(dist, name=metric_name, step=step)
# Additional statistics
Expand All @@ -196,7 +196,7 @@ def log_agent_vars(
else:
# Multiple values, use Distribution
dist = Distribution(
distribution=numeric_series, bin_count=self._bin_count
samples=numeric_series, bin_count=self._bin_count
)
self._run.track(dist, name=metric_name, step=step)

Expand Down Expand Up @@ -258,7 +258,7 @@ def log_agent_vars(
)
else:
dist = Distribution(
distribution=numeric_series, bin_count=self._bin_count
samples=numeric_series, bin_count=self._bin_count
)
self._run.track(dist, name=metric_name, step=step)
except (TypeError, ValueError):
Expand Down
4 changes: 2 additions & 2 deletions tests/utils/test_aim_tracker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ def mock_distribution_class():

# Create a mock Distribution class when aim is not available
# It should be callable (a class), not an instance
def create_mock_distribution(distribution, bin_count=64):
def create_mock_distribution(samples, bin_count=64):
"""Create a mock Distribution instance."""
mock_instance = MagicMock()
mock_instance.bin_count = bin_count
Expand Down Expand Up @@ -92,7 +92,7 @@ def aim_tracker_custom_bin(mock_aim_run):
dist_class = Distribution
else:

def create_mock_distribution(distribution, bin_count=100):
def create_mock_distribution(samples, bin_count=100):
"""Create a mock Distribution instance with custom bin_count."""
mock_instance = MagicMock()
mock_instance.bin_count = bin_count
Expand Down
Loading