set dirty flag when using xform field setters #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks for reporting the bug. |
Author
|
Thanks Alan! Sorry about closing the other one, wasn't sure what the guidelines were there. 😅 |
Contributor
|
No problem, and thanks for finding and fixing bugs. |
jethac
force-pushed
the
v3dmath-xform-set-dirty-flag
branch
from
fa5cd95 to
59f9234
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per topic - I noticed that the setters on LvEdEngine::Transform weren't setting the dirty flag, so whenever you'd ask for the matrix later you'd get the identity matrix set at init time.