Rewrite to support client-side addons #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use m_MountedAddons as the server-side addon list - Remove unnecessary interface class
xen-000
requested changes
Apr 30, 2025
Collaborator
xen-000
left a comment
xen-000
left a comment
There was a problem hiding this comment.
Just went through the changes and I have some remarks. Will test them later.
public/imultiaddonmanager.h
Outdated
Comment on lines
48
to
50
| // Check whether the server is connected to the game coordinator, and therefore is capable of downloading addons. | ||
| // Should be called before calling DownloadAddon. | ||
| virtual bool HasGCConnection() = 0; |
Collaborator
There was a problem hiding this comment.
You mean Steam UGC (user-generated content), not the game coordinator.
Contributor
Author
There was a problem hiding this comment.
I renamed this function to HasUGCConnection instead for the lack of better name.
| clientInfo.lastActiveTime = Plat_FloatTime(); | ||
|
|
||
| // Server copies the CUtlString from CNetworkGameServer to this client. | ||
| CUtlString *addons = (CUtlString *)((uintptr_t)server + 328); |
Collaborator
There was a problem hiding this comment.
Is this offset the same on linux?
Contributor
Author
There was a problem hiding this comment.
Yes, it's the same in both platforms.
xen-000
approved these changes
May 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also use m_MountedAddons as the server-side addon list and remove unnecessary interface class.
Resolves #20 and #30.