Fixed file explorer - Mostly error handling#19
Open
Dyst0rti0n wants to merge 2 commits intoSourcewareLab:devfrom
Open
Fixed file explorer - Mostly error handling#19Dyst0rti0n wants to merge 2 commits intoSourcewareLab:devfrom
Dyst0rti0n wants to merge 2 commits intoSourcewareLab:devfrom
Conversation
…d several critical flaws that could lead to a nil pointer deference:
Member
|
I came across another error yesterday in file explorer, a user should not be allowed to delete the root folder. While he is allowed rn i beleive. |
Author
AH yes that would occur actually, nice spot. Going to do a bit more tonight and get more understanding into the code. Very nice build thus far I might say. Great project and it's wrote in the holy grail - Go |
Member
|
Thank! Means a lot |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Refresh() method in the file explorer model could lead to a nil pointer dereference with different flaws:
in an index of -1.