Skip to content

Bugfix: standard-images-check ABORTing when image_source not set #1009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 4, 2025
Merged

Bugfix: standard-images-check ABORTing when image_source not set #1009

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Tests/iaas/scs_0104_standard_images/standard_images.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,13 +72,13 @@ def compute_scs_0104_source(image_lookup, image_spec):
matches = _lookup_images(image_lookup, image_spec)
errors = 0
for image in matches:
img_source = image.properties['image_source']
img_source = image.properties.get('image_source', '')
sources = image_spec['source']
if not isinstance(sources, (tuple, list)):
sources = [sources]
if not any(img_source.startswith(src) for src in sources):
errors += 1
logger.error(f"Image '{image.name}' source mismatch: {img_source} matches none of these prefixes: {', '.join(sources)}")
logger.error(f"Image '{image.name}' source mismatch: '{img_source}' matches none of these prefixes: {', '.join(sources)}")
return not errors


Expand Down