Skip to content

Create compile fixes #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Create compile fixes #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6151378
small edit to DivingHelmetItem and RemainingAirOverlay to fix compile…
ner24 Aug 9, 2025
c0365d0
updated ItemVaultBlockEntity neighbour updates to reflect changes to …
ner24 Aug 10, 2025
cbf6422
fixed out of date variable after pos update in ItemVaultBlockEntity#u…
ner24 Aug 10, 2025
7558586
updated logic (again) for comparator updates from Item vault
ner24 Aug 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/main/java/com/simibubi/create/content/equipment/armor/DivingHelmetItem.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,6 @@ public static void breatheUnderwater(LivingEntity entity) {
if (entity instanceof ServerPlayer sp)
AllAdvancements.DIVING_SUIT.awardTo(sp);

event.setCanBreathe(true);
event.setCanRefillAir(true);
entity.setAirSupply(entity.getMaxAirSupply());
}
}
1 change: 0 additions & 1 deletion src/main/java/com/simibubi/create/content/equipment/armor/RemainingAirOverlay.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
import net.minecraft.client.gui.GuiGraphics;
import net.minecraft.client.player.LocalPlayer;
import net.minecraft.network.chat.Component;
import net.minecraft.tags.FluidTags;
import net.minecraft.util.StringUtil;
import net.minecraft.world.item.ItemStack;
import net.minecraft.world.level.GameType;
Expand Down
12 changes: 9 additions & 3 deletions src/main/java/com/simibubi/create/content/logistics/vault/ItemVaultBlockEntity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@
import java.util.List;
import java.util.Set;

import io.github.fabricators_of_create.porting_lib.block.NeighborChangeListeningBlock;

import org.jetbrains.annotations.Nullable;

import com.simibubi.create.AllBlockEntityTypes;
Expand Down Expand Up @@ -162,12 +164,16 @@ private static void updateComaratorsInner(Level level, Block provokingBlock, Blo
}

BlockState blockstate = level.getBlockState(updatePos);
blockstate.onNeighborChange(level, updatePos, provokingPos);
if (blockstate.getBlock() instanceof NeighborChangeListeningBlock nclb) {
nclb.onNeighborChange(blockstate, level, updatePos, provokingPos);
}
if (blockstate.isRedstoneConductor(level, updatePos)) {
updatePos.move(direction);
blockstate = level.getBlockState(updatePos);
if (blockstate.getWeakChanges(level, updatePos)) {
level.neighborChanged(blockstate, updatePos, provokingBlock, provokingPos, false);
if (blockstate.getBlock() instanceof NeighborChangeListeningBlock nclb) {
if (nclb.getWeakChanges(blockstate, level, updatePos)) {
level.neighborChanged(blockstate, updatePos, provokingBlock, provokingPos, false);
}
}
}
}
Expand Down