Conversation
- Add expr_retain() in all Python atom bindings to properly increment refcount when capsules are created. Without this, expression trees were getting double-freed when Python garbage collected capsules. - Add wsum_hess_init and eval_wsum_hess to constant.c. Constants were missing Hessian functions, causing NULL pointer crash when constraint expressions contained constants (e.g., "0 + -log(x)"). - Add Python bindings for problem_hessian (python/problem/hessian.h) - Add hessian() method to C_problem class in convert.py - Add comprehensive Hessian tests to test_constrained.py Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This reverts commit 2eb7554.
Collaborator
Collaborator
Author
|
Merging this so I can merge your code easily |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I want to write a few tests by hand before I think this is ready to be merged.