Skip to content

Add Prod atom Python binding#24

Merged
dance858 merged 1 commit intomainfrom
prod-bindings
Jan 14, 2026
Merged

Add Prod atom Python binding#24
dance858 merged 1 commit intomainfrom
prod-bindings

Conversation

@Transurgeon
Copy link
Collaborator

  • Add python/atoms/prod.h binding header
  • Register make_prod in bindings.c method table
  • Add Prod converter in init.py ATOM_CONVERTERS

Note: Only full product supported (no axis parameter yet)

- Add python/atoms/prod.h binding header
- Register make_prod in bindings.c method table
- Add Prod converter in __init__.py ATOM_CONVERTERS

Note: Only full product supported (no axis parameter yet)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@Transurgeon
Copy link
Collaborator Author

Transurgeon commented Jan 14, 2026

@dance858 really nice progress. you are an efficient derivative writing machine!
We are almost passing all the nlp tests already.. thanks to all your coverage.
Remaining failures (12 total):
┌──────────────────────────────────┬───────┐
│ Missing Feature │ Count │
├──────────────────────────────────┼───────┤
│ broadcast_to │ 5 │
├──────────────────────────────────┼───────┤
│ MulExpression (bivariate matmul) │ 5 │
├──────────────────────────────────┼───────┤
│ Prod with axis │ 1 │
├──────────────────────────────────┼───────┤
│ rel_entr scalar │ 1 │
└──────────────────────────────────┴───────┘
apparently only these tests are failing now.
I can start thinking about broadcast_to.. it will be helpful, what do you think?

@dance858
Copy link
Collaborator

Awesome, thank you!

I have been working on broadcasting today. Maybe you can take a look at rel_entr scalar or prod_with_axis?

@dance858 dance858 merged commit 3ae98b5 into main Jan 14, 2026
0 of 9 checks passed
@dance858 dance858 deleted the prod-bindings branch February 1, 2026 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants