Remove Python packaging, integrate as DNLP submodule#37
Merged
Conversation
- Remove pyproject.toml (Python packaging now handled by CVXPY) - Remove src/dnlp_diff_engine/ Python wrapper (no longer needed) - Add Apache 2.0 LICENSE file Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Update module name to _diffengine for integration with CVXPY build system. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Document the new workflow where Python packaging is handled by CVXPY. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Implements diag_vec which converts a vector of size n into an n×n diagonal matrix. Includes forward pass, Jacobian, and Hessian computations. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Use standard CSR building pattern (J->p[row] = nnz) - Use next_diag counter instead of checking row == child_row * (n+1) - Simplify eval_jacobian to O(n) loop computing out_row directly Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Collaborator
|
Very clean. Nice. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pyproject.toml- Python packaging now handled by CVXPY build systemsrc/dnlp_diff_engine/Python wrapper - no longer needed_coreto_diffenginefor CVXPY integrationdiag_vecatom implementationContext
This prepares diff-engine to be used as a git submodule in CVXPY. The C extension is now
built directly by CVXPY's setup.py, eliminating the need for separate Python packaging.
Test plan
cmake -B build && cmake --build build && ./build/all_testspassespip install -e .