feat: Expand pay-for-protection to allotment and hops patches#81
Open
filipecouto wants to merge 4 commits intoSpeaax:masterfrom
Open
feat: Expand pay-for-protection to allotment and hops patches#81filipecouto wants to merge 4 commits intoSpeaax:masterfrom
filipecouto wants to merge 4 commits intoSpeaax:masterfrom
Conversation
Adds pay-for-protection support for allotment patches (Elstan, Dantaera, Kragen, Marisi, Lyra, Alan, Harminia) and hops patches (Vasquen, Rhonen, Selena, Brother Althric, Ercos). Includes NPC dialog detection for "already looking after that patch" message, noted item canonicalization fix, and Civitas/Yanille teleport updates.
The Civitas farming area spans multiple regions. Walking from the AJP fairy ring (region 6447) through region 6448 to the patches (region 6192) caused the run to end because 6448 was not recognized as Civitas.
Author
|
Hi, I recently started playing OSRS again and noticed that the plugin wasn't supporting pay for protection in hops / allotments, so I added those and have been testing locally with my severely underleveled account. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Expands pay-for-protection support beyond tree/fruit tree patches to cover herb, flower, allotment, and hops patches.
Pay-for-protection: Herb patches
Pay-for-protection: Flower patches
Pay-for-protection: Allotment patches
Pay-for-protection: Hops patches
Other changes
Test plan