Fix habit streak counter to require full daily completion of targetGoal#25
Merged
JoeProgrammer88 merged 2 commits intomainfrom Mar 1, 2026
Merged
Conversation
Co-authored-by: JoeProgrammer88 <7156063+JoeProgrammer88@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix incorrect calculation of streak counter for habits
Fix habit streak counter to require full daily completion of targetGoal
Mar 1, 2026
JoeProgrammer88
approved these changes
Mar 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Streak was incremented on every individual log entry regardless of
targetGoal, and had no consecutive-day validation — logging on day 1 and day 3 would produce a streak of 2.Changes
calculateHabitStreak()(new) — derives streak by grouping logs by date, filtering to days wherecount >= targetGoal, then walking backward through sorted dates counting consecutive days from the most recent fully-completed daylogHabitCompletion()— replacesstreak + 1with a call tocalculateHabitStreak()on the current log state, so retroactive completions (filling a gap in past days) are correctly reflectedOriginal prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.