Fix Wishlist touch interactions broken on iOS#50
Merged
JoeProgrammer88 merged 2 commits intomainfrom Mar 21, 2026
Merged
Conversation
The touchstart handler was immediately entering drag mode and the touchmove handler unconditionally called preventDefault(), which suppressed synthetic click events on iOS/Safari for child elements (checkbox, edit button, View Listing link). Fix: only activate drag mode when touch moves beyond a 10px threshold, only call preventDefault() when drag mode is active, and skip drag logic in touchend when no drag was initiated. touchstart is now passive:true since we no longer call preventDefault() there. Co-authored-by: JoeProgrammer88 <7156063+JoeProgrammer88@users.noreply.github.com> Agent-Logs-Url: https://github.com/SpeakingInBits/TaskManagerWeb/sessions/e94c6188-f1fa-4385-ad79-c8a2282534f0
Copilot
AI
changed the title
[WIP] Fix interaction issues on Wishlist page
Fix Wishlist touch interactions broken on iOS
Mar 21, 2026
JoeProgrammer88
approved these changes
Mar 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
iOS users couldn't interact with Wishlist items (checkbox, Edit button, View Listing link) because the touch drag-and-drop handlers were unconditionally calling
e.preventDefault()on everytouchmove, suppressing the synthetic click events Safari generates for child elements. Android/Chrome tolerates this; iOS does not.Changes
touchstartno longer immediately sets drag state — it now only records the start position (passive: true)touchmoveactivates drag mode only after touch displacement exceeds 10px;e.preventDefault()is only called once drag is confirmed activetouchend: skips all drag/reorder logic when no drag was initiated, letting normal tap events propagateTouch drag-and-drop reordering continues to work as before.
Original prompt
🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.