Skip to content

Finance: remove Other Charges, add expense pie chart and Sankey diagram#60

Merged
JoeProgrammer88 merged 3 commits intomainfrom
copilot/remove-other-charges-option
Mar 26, 2026
Merged

Finance: remove Other Charges, add expense pie chart and Sankey diagram#60
JoeProgrammer88 merged 3 commits intomainfrom
copilot/remove-other-charges-option

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 25, 2026

Removes the Other Charges option from the Finance page and replaces it with a Charts tab containing an SVG pie chart and Sankey diagram for visualizing spending.

Removed

  • Other Charges button, tab, list, and all related logic (renderCharges, charge branches in saveFinance/deleteFinance/openFinanceModal, charge contribution to updateFinanceSummary)

Added

  • Charts tab replacing the Other Charges tab, with two visualizations implemented in pure SVG (no external dependencies):
    • Expense pie chart — breaks down expenses by category with a color-coded legend and percentage labels
    • Sankey diagram — shows proportional flow from income sources to expense categories

Summary card update

updateFinanceSummary now computes totals from expenses and revenue only; charges no longer factor into the net balance.


Finance Charts

Original prompt

This section details on the original issue you should resolve

<issue_title>Remove "Other Charges"</issue_title>
<issue_description>Remove the other charges option from the Finance page. Users would also like to be able to visualize their spending (expenses) with a pie chart and Sankey diagram.</issue_description>

Comments on the Issue (you are @copilot in this section)


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI changed the title [WIP] Remove other charges option from Finance page Finance: remove Other Charges, add expense pie chart and Sankey diagram Mar 25, 2026
Copilot AI requested a review from JoeProgrammer88 March 25, 2026 23:09
Copy link
Copy Markdown
Member

@JoeProgrammer88 JoeProgrammer88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The other charges related tests need to be removed

@JoeProgrammer88
Copy link
Copy Markdown
Member

@copilot try again

@JoeProgrammer88
Copy link
Copy Markdown
Member

@copilot try again

Co-authored-by: JoeProgrammer88 <7156063+JoeProgrammer88@users.noreply.github.com>
Agent-Logs-Url: https://github.com/SpeakingInBits/TaskManagerWeb/sessions/eb4cb3db-a950-49e7-a90d-e52ab518e9e9
Copy link
Copy Markdown
Contributor Author

Copilot AI commented Mar 26, 2026

@copilot try again

Done in commit 61aba2c. Removed the charge management describe block (3 tests) from tests/storage.test.ts and updated the e2e tab-switching test in e2e/app.spec.ts to use the charts tab instead of charges. All 84 remaining tests pass.

@JoeProgrammer88 JoeProgrammer88 marked this pull request as ready for review March 26, 2026 00:50
@JoeProgrammer88 JoeProgrammer88 merged commit 1decfa9 into main Mar 26, 2026
1 check passed
@JoeProgrammer88 JoeProgrammer88 deleted the copilot/remove-other-charges-option branch March 26, 2026 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove "Other Charges"

2 participants