Skip to content

NPC's spell cast range #1524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
canerksk wants to merge 5 commits into
base: dev
Choose a base branch
from
Open

NPC's spell cast range #1524

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ca93f6a
NPC's spell cast range
canerksk Nov 25, 2025
3edf64c
Change max distance key from OVERRIDE.MAXDIST to OVERRIDE.SPELL_MAXDIST
cbnolok Dec 5, 2025
ac8b1f3
Revise NPC casting distance and add new tag for max distance
cbnolok Dec 5, 2025
63180d4
Merge branch 'dev' into 1439
cbnolok Dec 5, 2025
e2aacea
Refine NPCs cast distance based on RANGE setting
cbnolok Dec 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions Changelog.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4094,3 +4094,7 @@ When setting a property like MORE to the a spell or skill defname, trying to rea
4-12-2025, Nolok
- Fixed: Malformed spell flags being returned via scripts.
- Fixed: REGION ISEVENT didn't (always?) find REGIONTYPES.

05-12-2025, canerksk
- Changed: NPCs cast distance now depends on the caster's RANGE (if set, otherwise fall back to the default value).
- Added: TAG.OVERRIDE.SPELL_MAXDIST to set a custom maximum distance from the target for spellcasting.
10 changes: 9 additions & 1 deletion src/game/chars/CCharNPCAct_Magic.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,8 +169,16 @@ bool CChar::NPC_FightMagery(CChar * pChar)
if ((iSpellCount < 1) && !pWand)
return false;

int iMaxDist = ((UO_MAP_VIEW_SIGHT * 3) / 4); // (14 * 3) / 4 = 10
if (pChar->_uiRange)
iMaxDist = pChar->_uiRange; // char range

CVarDefCont *pValueMaxDist = GetKey("OVERRIDE.SPELL_MAXDIST", true);
if (pValueMaxDist)
iMaxDist = (int)pValueMaxDist->GetValNum();

int iDist = GetTopDist3D(pChar);
if (iDist > ((UO_MAP_VIEW_SIGHT * 3) / 4)) // way too far away . close in.
if (iDist > iMaxDist) // way too far away . close in.
return false;

if ((iDist <= 1) && (Skill_GetBase(SKILL_TACTICS) > 200) && (!g_Rand.GetVal(2)))
Expand Down