Skip to content

Fix artifact removal padding logic #4245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mhhennig wants to merge 4 commits into
base: main
Choose a base branch
from
+5 −3
Open

Fix artifact removal padding logic #4245

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2bd3f4b
Fix artifact removal logic to handle padding correctly in RemoveArtif…
mhhennig Dec 5, 2025
ba891d3
Merge branch 'main' into artifacts_fix
mhhennig Dec 5, 2025
5d073b1
Update src/spikeinterface/preprocessing/remove_artifacts.py
mhhennig Dec 5, 2025
ff44ccc
Merge branch 'SpikeInterface:main' into artifacts_fix
mhhennig Dec 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/spikeinterface/preprocessing/remove_artifacts.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,12 +263,14 @@ def get_traces(self, start_frame, end_frame, channel_indices):
traces = self.parent_recording_segment.get_traces(start_frame, end_frame, channel_indices)
traces = traces.copy()

mask = (self.triggers >= start_frame) & (self.triggers < end_frame)
pad = self.pad
if pad is None:
mask = (self.triggers >= start_frame) & (self.triggers < end_frame)
else:
mask = (self.triggers >= start_frame - pad[1]) & (self.triggers < end_frame + pad[0])
Copy link
Member

@alejoe91 alejoe91 Dec 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
mask = (self.triggers >= start_frame - pad[1]) & (self.triggers < end_frame + pad[0])
mask = (self.triggers >= start_frame - pad[0]) & (self.triggers < end_frame + pad[1])

pad is defined as pad = [int(ms_before * fs / 1000), int(ms_after * fs / 1000)]

triggers = self.triggers[mask] - start_frame
labels = self.labels[mask]

pad = self.pad

if self.mode == "zeros":
for trig in triggers:
if pad is None:
Expand Down