Removing hdbscan dependency #4259
Closed
+43
−42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
Member
|
Nice! How similar do you think the implementations are? |
for more information, see https://pre-commit.ci
yger
added
enhancement
Collaborator
Author
|
Same paper, same reference, but I have not performed an exhaustive comparison. Based on preliminary results from the sorters (the only part really using hdbscan), performances are similar. Maybe we should compare more in depth |
Collaborator
Author
|
Ok, after a more exhaustive study, looks like indeed hdbscan is a better implementation than scikit-learn 
Here for example, I generated 10 Gaussian blobs, and computed averaged run times and homogeneity scores for the two implementations. Looks like hdbscan is faster, and more accurate |
Member
|
So we close!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in line with #4257 , but maybe one option would be to get rid of HDBSCAN dependency, since now there is a full port in scikit-learn. At the time we started to use hdbscan, this was not the case, but now maybe this would be a good option to ease maintenance and install procedures.
This PR removes all usages of hdbscan to only rely on scikit. In fact, some advanced options of hdbscan are not ported into the scikit-learn version, but since they are not used anywhere in the code at the moment...