Skip to content

Comments

Miscellaneous improvements#120

Merged
dpikhulya merged 11 commits intomasterfrom
misc-fixes
May 19, 2025
Merged

Miscellaneous improvements#120
dpikhulya merged 11 commits intomasterfrom
misc-fixes

Conversation

@dpikhulya
Copy link
Contributor

@dpikhulya dpikhulya commented May 18, 2025

This PR includes the following:

  • Adds field color customization properties to InputField and DropdownSelector.
  • Adds Money.format() extension, which, unlike the existing Money.formatAmount(), also includes the currency code, which provides a full set of information about the money value that is sufficient to understand its value.
  • Ensures that subscriptions made by the Wizard component are cancelled when the "Cancel" button is pressed.
  • Simplifies ComponentSetup declarations (no explicit instance creation is required now). The component's type instantiation is inferred from the ComponentSetup's type parameter automatically (using the same mechanism that is used in EntityChooser).
  • Removes the dependency of the core module to codegen-runtime to prevent inheriting its transitive dependency on protobuf lib(s). According to the Chord's design, Protobuf dependencies can appear "starting" from chords-proto-values (in those libs that depend on it).

@dpikhulya dpikhulya changed the title Miscellaneous fixes Miscellaneous improvements May 18, 2025
@dpikhulya dpikhulya self-assigned this May 18, 2025
@dpikhulya dpikhulya requested review from Oleg-Melnik and armiol May 19, 2025 01:56
@dpikhulya
Copy link
Contributor Author

@armiol As discussed with Oleg, to speed up rolling out the release, I'm planning to merge this PR as soon as he accepts it. I'll address your comments in a subsequent PR anyway, so please feel free to submit your review even after I merge the PR.

@dpikhulya dpikhulya merged commit 75cc0f2 into master May 19, 2025
5 checks passed
@dpikhulya dpikhulya deleted the misc-fixes branch May 19, 2025 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants